third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp - Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3) (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

index 2eecc86e1944d4e30c278edeca5dad2505a42ab3..42f8af7a3c61194dd7cb3eae0f64eb79a9b3a460 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

@@ -29,7 +29,8 @@ V8IntersectionObserverCallback::~V8IntersectionObserverCallback() {}

void V8IntersectionObserverCallback::HandleEvent(

const HeapVector<Member<IntersectionObserverEntry>>& entries,

IntersectionObserver& observer) {

- ExecutionContext* execution_context = script_state_->GetExecutionContext();

+ ExecutionContext* execution_context =

+ ExecutionContext::From(script_state_.Get());

if (!execution_context || execution_context->IsContextSuspended() ||

execution_context->IsContextDestroyed())

return;

@@ -58,7 +59,7 @@ void V8IntersectionObserverCallback::HandleEvent(

v8::TryCatch exception_catcher(script_state_->GetIsolate());

exception_catcher.SetVerbose(true);

V8ScriptRunner::CallFunction(callback_.NewLocal(script_state_->GetIsolate()),

- script_state_->GetExecutionContext(),

+ ExecutionContext::From(script_state_.Get()),

this_object, 2, argv,

script_state_->GetIsolate());

}