DescriptionReland of Initialize default audio device ID with explicit device ID. (patchset #1 id:1 of https://codereview.chromium.org/2813543005/ )
Reason for revert:
Will attempt to reland by reverting changes in MSM and updating extensions test.
Original issue's description:
> Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ )
>
> Reason for revert:
> Patchset 2 restores the behavior I wanted to eliminate.
>
> Original issue's description:
> > Initialize default audio device ID with explicit device ID.
> >
> > This is more consistent with how video device IDs are specified and is
> > also a small first step towards implementing the standard constraints
> > algorithm for audio.
> > This CL disables a misleading selector that allows switching the
> > user-preferred device in the middle of a getUserMedia call.
> > Since that selector does not affect the current getUserMedia call, it
> > is better to have it disabled, which is already the case with video
> > devices.
> >
> > BUG=708081
> >
> > Review-Url: https://codereview.chromium.org/2812903002
> > Cr-Commit-Position: refs/heads/master@{#463624}
> > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d
>
> TBR=hbos@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=708081
>
> Review-Url: https://codereview.chromium.org/2813543005
> Cr-Commit-Position: refs/heads/master@{#463634}
> Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708081
Review-Url: https://codereview.chromium.org/2809043004
Cr-Commit-Position: refs/heads/master@{#463710}
Committed: https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42
Patch Set 1 #Patch Set 2 : revert changes in MSM and update extensions test #Patch Set 3 : rebase #
Total comments: 1
Patch Set 4 : address mek's comments #
Messages
Total messages: 26 (18 generated)
|