Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2809043004: Reland of Initialize default audio device ID with explicit device ID. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Initialize default audio device ID with explicit device ID. (patchset #1 id:1 of https://codereview.chromium.org/2813543005/ ) Reason for revert: Will attempt to reland by reverting changes in MSM and updating extensions test. Original issue's description: > Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ ) > > Reason for revert: > Patchset 2 restores the behavior I wanted to eliminate. > > Original issue's description: > > Initialize default audio device ID with explicit device ID. > > > > This is more consistent with how video device IDs are specified and is > > also a small first step towards implementing the standard constraints > > algorithm for audio. > > This CL disables a misleading selector that allows switching the > > user-preferred device in the middle of a getUserMedia call. > > Since that selector does not affect the current getUserMedia call, it > > is better to have it disabled, which is already the case with video > > devices. > > > > BUG=708081 > > > > Review-Url: https://codereview.chromium.org/2812903002 > > Cr-Commit-Position: refs/heads/master@{#463624} > > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d > > TBR=hbos@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=708081 > > Review-Url: https://codereview.chromium.org/2813543005 > Cr-Commit-Position: refs/heads/master@{#463634} > Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72 # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708081 Review-Url: https://codereview.chromium.org/2809043004 Cr-Commit-Position: refs/heads/master@{#463710} Committed: https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42

Patch Set 1 #

Patch Set 2 : revert changes in MSM and update extensions test #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : address mek's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M content/renderer/media/user_media_client_impl.cc View 1 3 chunks +8 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
Guido Urdaneta
Created Reland of Initialize default audio device ID with explicit device ID.
3 years, 8 months ago (2017-04-11 15:53:16 UTC) #1
Guido Urdaneta
mek@chromium.org: Please review changes in extensions/
3 years, 8 months ago (2017-04-11 15:55:36 UTC) #3
Marijn Kruisselbrink
https://codereview.chromium.org/2809043004/diff/150001/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc File extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc (right): https://codereview.chromium.org/2809043004/diff/150001/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc#newcode77 extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc:77: base::CommandLine::ForCurrentProcess()->AppendSwitch( nit: To add command line flags you should ...
3 years, 8 months ago (2017-04-11 18:02:18 UTC) #16
Guido Urdaneta
mek@: Please take another look
3 years, 8 months ago (2017-04-11 18:38:19 UTC) #17
Marijn Kruisselbrink
lgtm
3 years, 8 months ago (2017-04-11 18:39:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809043004/170001
3 years, 8 months ago (2017-04-11 18:42:15 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:170001) as https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42
3 years, 8 months ago (2017-04-11 19:06:06 UTC) #25
Guido Urdaneta
3 years, 8 months ago (2017-04-22 17:25:05 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:170001) has been created in
https://codereview.chromium.org/2829403002/ by guidou@chromium.org.

The reason for reverting is: Causes http://crbug.com/714386.

Powered by Google App Engine
This is Rietveld 408576698