Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2813543005: Revert of Initialize default audio device ID with explicit device ID. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ ) Reason for revert: Patchset 2 restores the behavior I wanted to eliminate. Original issue's description: > Initialize default audio device ID with explicit device ID. > > This is more consistent with how video device IDs are specified and is > also a small first step towards implementing the standard constraints > algorithm for audio. > This CL disables a misleading selector that allows switching the > user-preferred device in the middle of a getUserMedia call. > Since that selector does not affect the current getUserMedia call, it > is better to have it disabled, which is already the case with video > devices. > > BUG=708081 > > Review-Url: https://codereview.chromium.org/2812903002 > Cr-Commit-Position: refs/heads/master@{#463624} > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d TBR=hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708081 Review-Url: https://codereview.chromium.org/2813543005 Cr-Commit-Position: refs/heads/master@{#463634} Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M content/browser/renderer_host/media/media_stream_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 3 chunks +1 line, -8 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of Initialize default audio device ID with explicit device ID.
3 years, 8 months ago (2017-04-11 15:07:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813543005/1
3 years, 8 months ago (2017-04-11 15:08:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72
3 years, 8 months ago (2017-04-11 15:09:42 UTC) #6
Guido Urdaneta
3 years, 8 months ago (2017-04-11 15:53:16 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2809043004/ by guidou@chromium.org.

The reason for reverting is: Will attempt to reland by reverting changes in MSM
and updating extensions test..

Powered by Google App Engine
This is Rietveld 408576698