Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2812903002: Initialize default audio device ID with explicit device ID. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize default audio device ID with explicit device ID. This is more consistent with how video device IDs are specified and is also a small first step towards implementing the standard constraints algorithm for audio. This CL disables a misleading selector that allows switching the user-preferred device in the middle of a getUserMedia call. Since that selector does not affect the current getUserMedia call, it is better to have it disabled, which is already the case with video devices. BUG=708081 Review-Url: https://codereview.chromium.org/2812903002 Cr-Commit-Position: refs/heads/master@{#463624} Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d

Patch Set 1 #

Patch Set 2 : fix handling of empty ID in MSM and DCHECKs, use kDefaultDeviceId in unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M content/browser/renderer_host/media/media_stream_manager.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 3 chunks +8 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Guido Urdaneta
3 years, 8 months ago (2017-04-11 10:49:21 UTC) #5
hbos_chromium
lgtm
3 years, 8 months ago (2017-04-11 11:00:49 UTC) #6
Guido Urdaneta
Can you take another look?
3 years, 8 months ago (2017-04-11 14:04:33 UTC) #11
hbos_chromium
lgtm
3 years, 8 months ago (2017-04-11 14:23:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812903002/20001
3 years, 8 months ago (2017-04-11 14:34:11 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d
3 years, 8 months ago (2017-04-11 14:39:44 UTC) #19
Guido Urdaneta
3 years, 8 months ago (2017-04-11 15:07:34 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2813543005/ by guidou@chromium.org.

The reason for reverting is: Patchset 2 restores the behavior I wanted to
eliminate. .

Powered by Google App Engine
This is Rietveld 408576698