Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: content/renderer/media/user_media_client_impl_unittest.cc

Issue 2809043004: Reland of Initialize default audio device ID with explicit device ID. (Closed)
Patch Set: address mek's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/user_media_client_impl.h" 5 #include "content/renderer/media/user_media_client_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/message_loop/message_loop.h" 13 #include "base/message_loop/message_loop.h"
14 #include "base/run_loop.h" 14 #include "base/run_loop.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "content/child/child_process.h" 16 #include "content/child/child_process.h"
17 #include "content/common/media/media_devices.h" 17 #include "content/common/media/media_devices.h"
18 #include "content/renderer/media/media_stream.h" 18 #include "content/renderer/media/media_stream.h"
19 #include "content/renderer/media/media_stream_audio_source.h" 19 #include "content/renderer/media/media_stream_audio_source.h"
20 #include "content/renderer/media/media_stream_track.h" 20 #include "content/renderer/media/media_stream_track.h"
21 #include "content/renderer/media/mock_constraint_factory.h" 21 #include "content/renderer/media/mock_constraint_factory.h"
22 #include "content/renderer/media/mock_media_stream_dispatcher.h" 22 #include "content/renderer/media/mock_media_stream_dispatcher.h"
23 #include "content/renderer/media/mock_media_stream_video_source.h" 23 #include "content/renderer/media/mock_media_stream_video_source.h"
24 #include "content/renderer/media/webrtc/mock_peer_connection_dependency_factory. h" 24 #include "content/renderer/media/webrtc/mock_peer_connection_dependency_factory. h"
25 #include "media/audio/audio_device_description.h"
25 #include "mojo/public/cpp/bindings/binding.h" 26 #include "mojo/public/cpp/bindings/binding.h"
26 #include "testing/gtest/include/gtest/gtest.h" 27 #include "testing/gtest/include/gtest/gtest.h"
27 #include "third_party/WebKit/public/platform/WebMediaDeviceInfo.h" 28 #include "third_party/WebKit/public/platform/WebMediaDeviceInfo.h"
28 #include "third_party/WebKit/public/platform/WebMediaStream.h" 29 #include "third_party/WebKit/public/platform/WebMediaStream.h"
29 #include "third_party/WebKit/public/platform/WebMediaStreamSource.h" 30 #include "third_party/WebKit/public/platform/WebMediaStreamSource.h"
30 #include "third_party/WebKit/public/platform/WebMediaStreamTrack.h" 31 #include "third_party/WebKit/public/platform/WebMediaStreamTrack.h"
31 #include "third_party/WebKit/public/platform/WebString.h" 32 #include "third_party/WebKit/public/platform/WebString.h"
32 #include "third_party/WebKit/public/platform/WebVector.h" 33 #include "third_party/WebKit/public/platform/WebVector.h"
33 #include "third_party/WebKit/public/web/WebHeap.h" 34 #include "third_party/WebKit/public/web/WebHeap.h"
34 35
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 TestValidRequestWithConstraints(audio_constraints, video_constraints, 894 TestValidRequestWithConstraints(audio_constraints, video_constraints,
894 kFakeAudioInputDeviceId1, 895 kFakeAudioInputDeviceId1,
895 kFakeVideoInputDeviceId1); 896 kFakeVideoInputDeviceId1);
896 } 897 }
897 898
898 TEST_F(UserMediaClientImplTest, CreateWithAllOptionalInvalidDeviceId) { 899 TEST_F(UserMediaClientImplTest, CreateWithAllOptionalInvalidDeviceId) {
899 blink::WebMediaConstraints audio_constraints = 900 blink::WebMediaConstraints audio_constraints =
900 CreateDeviceConstraints(nullptr, kInvalidDeviceId, kInvalidDeviceId); 901 CreateDeviceConstraints(nullptr, kInvalidDeviceId, kInvalidDeviceId);
901 blink::WebMediaConstraints video_constraints = 902 blink::WebMediaConstraints video_constraints =
902 CreateDeviceConstraints(nullptr, kInvalidDeviceId, kInvalidDeviceId); 903 CreateDeviceConstraints(nullptr, kInvalidDeviceId, kInvalidDeviceId);
903 // MockMediaStreamDispatcher uses empty string as default audio device ID.
904 // MockMediaDevicesDispatcher uses the first device in the enumeration as 904 // MockMediaDevicesDispatcher uses the first device in the enumeration as
905 // default video device ID. 905 // default video device ID.
906 TestValidRequestWithConstraints(audio_constraints, video_constraints, 906 TestValidRequestWithConstraints(
907 std::string(), kFakeVideoInputDeviceId1); 907 audio_constraints, video_constraints,
908 std::string(media::AudioDeviceDescription::kDefaultDeviceId),
909 kFakeVideoInputDeviceId1);
908 } 910 }
909 911
910 TEST_F(UserMediaClientImplTest, CreateWithFacingModeUser) { 912 TEST_F(UserMediaClientImplTest, CreateWithFacingModeUser) {
911 blink::WebMediaConstraints audio_constraints = 913 blink::WebMediaConstraints audio_constraints =
912 CreateDeviceConstraints(kFakeAudioInputDeviceId1); 914 CreateDeviceConstraints(kFakeAudioInputDeviceId1);
913 blink::WebMediaConstraints video_constraints = 915 blink::WebMediaConstraints video_constraints =
914 CreateFacingModeConstraints("user"); 916 CreateFacingModeConstraints("user");
915 // kFakeVideoInputDeviceId1 has user facing mode. 917 // kFakeVideoInputDeviceId1 has user facing mode.
916 TestValidRequestWithConstraints(audio_constraints, video_constraints, 918 TestValidRequestWithConstraints(audio_constraints, video_constraints,
917 kFakeAudioInputDeviceId1, 919 kFakeAudioInputDeviceId1,
918 kFakeVideoInputDeviceId1); 920 kFakeVideoInputDeviceId1);
919 } 921 }
920 922
921 TEST_F(UserMediaClientImplTest, CreateWithFacingModeEnvironment) { 923 TEST_F(UserMediaClientImplTest, CreateWithFacingModeEnvironment) {
922 blink::WebMediaConstraints audio_constraints = 924 blink::WebMediaConstraints audio_constraints =
923 CreateDeviceConstraints(kFakeAudioInputDeviceId1); 925 CreateDeviceConstraints(kFakeAudioInputDeviceId1);
924 blink::WebMediaConstraints video_constraints = 926 blink::WebMediaConstraints video_constraints =
925 CreateFacingModeConstraints("environment"); 927 CreateFacingModeConstraints("environment");
926 // kFakeVideoInputDeviceId2 has environment facing mode. 928 // kFakeVideoInputDeviceId2 has environment facing mode.
927 TestValidRequestWithConstraints(audio_constraints, video_constraints, 929 TestValidRequestWithConstraints(audio_constraints, video_constraints,
928 kFakeAudioInputDeviceId1, 930 kFakeAudioInputDeviceId1,
929 kFakeVideoInputDeviceId2); 931 kFakeVideoInputDeviceId2);
930 } 932 }
931 933
932 } // namespace content 934 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698