Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2809023002: Replace ASSERT/ASSERT_NOT_REACHED with DCHECK/NOTREACHED in modules/webaudio (Closed)

Created:
3 years, 8 months ago by hongchan
Modified:
3 years, 8 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL changes ASSERT/ASSERT_NOT_REACHED to DCHECK/NOTREACHED mechanically, replacing the assertion with a single argument only. I used the following script: ``` cd ${CHROME_SRC}/third_party/WebKit/Source/modules/webaudio find . -type f -exec sed -i -E 's:ASSERT_NOT_REACHED:NOTREACHED:g' {} \; find . -type f -exec sed -i -E 's:(\s)ASSERT\(([^ ]+)\)\;:\1DCHECK\(\2\)\;:g' {} \; ``` With this CL the following script returns 0 result: ``` cd ${CHROME_SRC}/third_party/WebKit/Source/modules/webaudio grep -rnw . -e 'ASSERT(' ``` BUG=707643 Review-Url: https://codereview.chromium.org/2809023002 Cr-Commit-Position: refs/heads/master@{#463485} Committed: https://chromium.googlesource.com/chromium/src/+/aab941796e90b42557028feefef8365d493b8651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -71 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 10 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/GainNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hongchan
PTAL.
3 years, 8 months ago (2017-04-10 22:34:33 UTC) #2
Raymond Toy
lgtm
3 years, 8 months ago (2017-04-10 22:39:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809023002/1
3 years, 8 months ago (2017-04-10 22:41:35 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 01:20:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aab941796e90b42557028feefef8...

Powered by Google App Engine
This is Rietveld 408576698