Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

Issue 2809023002: Replace ASSERT/ASSERT_NOT_REACHED with DCHECK/NOTREACHED in modules/webaudio (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
index a3ea06ea0a2fbfce1d28190fe5b9839619cc4f43..769e6004c908756f39183ea03792aff1008981be 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
@@ -675,7 +675,7 @@ void BaseAudioContext::RemoveFinishedSourceNodesOnMainThread() {
}
bool BaseAudioContext::ReleaseFinishedSourceNodes() {
- ASSERT(IsGraphOwner());
+ DCHECK(IsGraphOwner());
DCHECK(IsAudioThread());
bool did_remove = false;
for (AudioHandler* handler : finished_source_handlers_) {
@@ -711,7 +711,7 @@ void BaseAudioContext::ReleaseActiveSourceNodes() {
}
void BaseAudioContext::HandleStoppableSourceNodes() {
- ASSERT(IsGraphOwner());
+ DCHECK(IsGraphOwner());
// Find AudioBufferSourceNodes to see if we can stop playing them.
for (AudioNode* node : active_source_nodes_) {
@@ -803,7 +803,7 @@ void BaseAudioContext::ResolvePromisesForResume() {
// This runs inside the BaseAudioContext's lock when handling pre-render
// tasks.
DCHECK(IsAudioThread());
- ASSERT(IsGraphOwner());
+ DCHECK(IsGraphOwner());
// Resolve any pending promises created by resume(). Only do this if we
// haven't already started resolving these promises. This gets called very

Powered by Google App Engine
This is Rietveld 408576698