third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp - Issue 2809023002: Replace ASSERT/ASSERT_NOT_REACHED with DCHECK/NOTREACHED in modules/webaudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

Issue 2809023002: Replace ASSERT/ASSERT_NOT_REACHED with DCHECK/NOTREACHED in modules/webaudio (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp ('k') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp b/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

index 8a55d01e85ea2d5bcabea4f9ffb88a4a8293d911..b65d2c793094af909e5d78d18e38a3ef2f1bd480 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

@@ -37,7 +37,7 @@ AudioSummingJunction::~AudioSummingJunction() {

}

void AudioSummingJunction::ChangedOutputs() {

- ASSERT(GetDeferredTaskHandler().IsGraphOwner());

+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());

if (!rendering_state_need_updating_) {

GetDeferredTaskHandler().MarkSummingJunctionDirty(this);

rendering_state_need_updating_ = true;

@@ -46,7 +46,7 @@ void AudioSummingJunction::ChangedOutputs() {

void AudioSummingJunction::UpdateRenderingState() {

DCHECK(GetDeferredTaskHandler().IsAudioThread());

- ASSERT(GetDeferredTaskHandler().IsGraphOwner());

+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());

if (rendering_state_need_updating_) {

// Copy from m_outputs to m_renderingOutputs.

rendering_outputs_.Resize(outputs_.size());