Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp

Issue 2809023002: Replace ASSERT/ASSERT_NOT_REACHED with DCHECK/NOTREACHED in modules/webaudio (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp b/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
index 8c0ebcf6a8a9a914619cc2c73b48cf5807156c96..d41908222e497fcb25a753c1bc121c3209c8ccae 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
@@ -44,7 +44,7 @@ std::unique_ptr<AudioNodeInput> AudioNodeInput::Create(AudioHandler& handler) {
}
void AudioNodeInput::Connect(AudioNodeOutput& output) {
- ASSERT(GetDeferredTaskHandler().IsGraphOwner());
+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());
// Check if we're already connected to this output.
if (outputs_.Contains(&output))
@@ -56,7 +56,7 @@ void AudioNodeInput::Connect(AudioNodeOutput& output) {
}
void AudioNodeInput::Disconnect(AudioNodeOutput& output) {
- ASSERT(GetDeferredTaskHandler().IsGraphOwner());
+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());
// First try to disconnect from "active" connections.
if (outputs_.Contains(&output)) {
@@ -77,11 +77,11 @@ void AudioNodeInput::Disconnect(AudioNodeOutput& output) {
return;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
void AudioNodeInput::Disable(AudioNodeOutput& output) {
- ASSERT(GetDeferredTaskHandler().IsGraphOwner());
+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());
DCHECK(outputs_.Contains(&output));
disabled_outputs_.insert(&output);
@@ -93,7 +93,7 @@ void AudioNodeInput::Disable(AudioNodeOutput& output) {
}
void AudioNodeInput::Enable(AudioNodeOutput& output) {
- ASSERT(GetDeferredTaskHandler().IsGraphOwner());
+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());
// Move output from disabled list to active list.
outputs_.insert(&output);
@@ -113,7 +113,7 @@ void AudioNodeInput::DidUpdate() {
void AudioNodeInput::UpdateInternalBus() {
DCHECK(GetDeferredTaskHandler().IsAudioThread());
- ASSERT(GetDeferredTaskHandler().IsGraphOwner());
+ DCHECK(GetDeferredTaskHandler().IsGraphOwner());
unsigned number_of_input_channels = NumberOfChannels();

Powered by Google App Engine
This is Rietveld 408576698