Added unresolved property argument to ParseSingleValue method

Added unresolved property argument to ParseSingleValue method

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyAnimationName and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012
Review-Url: https://codereview.chromium.org/2808383008
Cr-Commit-Position: refs/heads/master@{#464311}
Committed: https://chromium.googlesource.com/chromium/src/+/7178db73ead99cf38ec82a0d5a514f6612fddf2d

[Bugs Nash, 2017-04-13 03:46:28]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 03:47:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-13 03:49:50]

bugsnash@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2017-04-13 04:29:56]

rs lgtm but I was wondering can this patch be delayed till
CSSPropertyTransitionTimingFunction and CSSPropertyAliasWebkitAnimationName are
implemented and need to use this variable. Unused variable sound like bad
programming practice to me. 

Depends on how an OWNER feels about this.

[Bugs Nash, 2017-04-13 04:38:42]

bugsnash@chromium.org changed reviewers:
+ alancutter@chromium.org

[Bugs Nash, 2017-04-13 04:39:55]

On 2017/04/13 at 04:29:56, nainar wrote:
> rs lgtm but I was wondering can this patch be delayed till
CSSPropertyTransitionTimingFunction and CSSPropertyAliasWebkitAnimationName are
implemented and need to use this variable. Unused variable sound like bad
programming practice to me. 
> 
> Depends on how an OWNER feels about this.

+alancutter for owners

Given the size of this patch I would like to keep it separate from
ParseSingleValue implementation for these properties (and they can't be
implemented at all without this patch), but will combine if you think it's
better Alan.

[alancutter (OOO until 2018), 2017-04-13 04:45:02]

lgtm. I would prefer that making use of this parameter were part of this patch
so that the addition is clearly justified but given the size of this patch
either approach is acceptable to me.

[Bugs Nash, 2017-04-13 04:45:33]

The CQ bit was unchecked by bugsnash@chromium.org

[Bugs Nash, 2017-04-13 04:45:35]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-04-13 04:46:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-04-13 04:47:13]

https://codereview.chromium.org/2808383008/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5
(right):

https://codereview.chromium.org/2808383008/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5:39:
parameters: "(CSSParserTokenRange&, const CSSParserContext&, CSSPropertyID)",
Can we give this parameter a name?

[Bugs Nash, 2017-04-13 05:07:21]

Description was changed from

==========
Added unresolved property argument to ParseSingleValue method

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyTransitionTimingFunction and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012
==========

to

==========
Added unresolved property argument to ParseSingleValue method

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyAnimationName and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012
==========

[commit-bot: I haz the power, 2017-04-13 05:34:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492058735428760, "parent_rev":
"a4eb8e01f972546913b22a605e31bd22c270cfe8", "commit_rev":
"7178db73ead99cf38ec82a0d5a514f6612fddf2d"}

[commit-bot: I haz the power, 2017-04-13 05:35:31]

Description was changed from

==========
Added unresolved property argument to ParseSingleValue method

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyAnimationName and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012
==========

to

==========
Added unresolved property argument to ParseSingleValue method

Added CSSPropertyID argument to ParseSingleValue method so that
unresolved property can be passed. This is required for some aliases
that have different parsing logic, e.g.
CSSPropertyAnimationName and
CSSPropertyAliasWebkitAnimationName.

Note that none of the existing implementations of ParseSingleValue use
the new CSSPropertyID argument that is passed to them, but future
implementations of this method in properties with different parsing
logic from their aliases will need to use this argument.

BUG=668012

Review-Url: https://codereview.chromium.org/2808383008
Cr-Commit-Position: refs/heads/master@{#464311}
Committed:
https://chromium.googlesource.com/chromium/src/+/7178db73ead99cf38ec82a0d5a51...
==========

[commit-bot: I haz the power, 2017-04-13 05:35:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7178db73ead99cf38ec82a0d5a51...