third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp - Issue 2808383008: Added unresolved property argument to ParseSingleValue method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp

Issue 2808383008: Added unresolved property argument to ParseSingleValue method (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantNumeric.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFragmentation.cpp » ('j') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp

index 50bad4690f91b07bc7adc3fb0864ba0db869935e..7daf99b419b5ba64f1328d788756e6753247c18a 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariationSettings.cpp

@@ -43,7 +43,8 @@ CSSFontVariationValue* ConsumeFontVariationTag(CSSParserTokenRange& range) {

const CSSValue* CSSPropertyAPIFontVariationSettings::parseSingleValue(

CSSParserTokenRange& range,

- const CSSParserContext& context) {

+ const CSSParserContext& context,

+ CSSPropertyID) {

DCHECK(RuntimeEnabledFeatures::cssVariableFontsEnabled());

if (range.Peek().Id() == CSSValueNormal)

return CSSPropertyParserHelpers::ConsumeIdent(range);