Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPosition.cpp

Issue 2808383008: Added unresolved property argument to ParseSingleValue method (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/properties/CSSPropertyAPIOffsetPosition.h" 5 #include "core/css/properties/CSSPropertyAPIOffsetPosition.h"
6 6
7 #include "core/css/CSSValuePair.h" 7 #include "core/css/CSSValuePair.h"
8 #include "core/css/parser/CSSParserContext.h" 8 #include "core/css/parser/CSSParserContext.h"
9 #include "core/css/parser/CSSPropertyParserHelpers.h" 9 #include "core/css/parser/CSSPropertyParserHelpers.h"
10 #include "core/frame/UseCounter.h" 10 #include "core/frame/UseCounter.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 const CSSValue* CSSPropertyAPIOffsetPosition::parseSingleValue( 14 const CSSValue* CSSPropertyAPIOffsetPosition::parseSingleValue(
15 CSSParserTokenRange& range, 15 CSSParserTokenRange& range,
16 const CSSParserContext& context) { 16 const CSSParserContext& context,
17 CSSPropertyID) {
17 CSSValueID id = range.Peek().Id(); 18 CSSValueID id = range.Peek().Id();
18 if (id == CSSValueAuto) 19 if (id == CSSValueAuto)
19 return CSSPropertyParserHelpers::ConsumeIdent(range); 20 return CSSPropertyParserHelpers::ConsumeIdent(range);
20 CSSValue* value = CSSPropertyParserHelpers::ConsumePosition( 21 CSSValue* value = CSSPropertyParserHelpers::ConsumePosition(
21 range, context.Mode(), CSSPropertyParserHelpers::UnitlessQuirk::kForbid); 22 range, context.Mode(), CSSPropertyParserHelpers::UnitlessQuirk::kForbid);
22 23
23 // Count when we receive a valid position other than 'auto'. 24 // Count when we receive a valid position other than 'auto'.
24 if (value && value->IsValuePair()) 25 if (value && value->IsValuePair())
25 context.Count(UseCounter::kCSSOffsetInEffect); 26 context.Count(UseCounter::kCSSOffsetInEffect);
26 return value; 27 return value;
27 } 28 }
28 29
29 } // namespace blink 30 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698