third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5 - Issue 2808383008: Added unresolved property argument to ParseSingleValue method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5

Issue 2808383008: Added unresolved property argument to ParseSingleValue method (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMargin.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetAnchor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5 b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5

index 98bc532649cfa907b95630bcc4321970594a771d..11355f8a1d5a64f45ca1daac35f40078b7734308 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMethods.json5

@@ -36,7 +36,7 @@

{

name: "parseSingleValue",

return_type: "const CSSValue*",

- parameters: "(CSSParserTokenRange&, const CSSParserContext&)",

+ parameters: "(CSSParserTokenRange&, const CSSParserContext&, CSSPropertyID)",

alancutter (OOO until 2018) 2017/04/13 04:47:12 Can we give this parameter a name?

description: "Parses a single CSS property and returns the corresponding CSSValue. If the input is invalid it returns nullptr.",

{