v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

"Detach the global object OR NOT" doesn't matter much, or it does not
make a good sense.  "detach the global object OR context's frame was
detached from the DOM" makes much more sense.

This CL replaces GlobalDetachmentBehavior with Lifecycle, and
emphasizes the latter point.

BUG=

Review-Url: https://codereview.chromium.org/2808093002
Cr-Commit-Position: refs/heads/master@{#463272}
Committed: https://chromium.googlesource.com/chromium/src/+/2bccabe644101b3215d4fc3d844e2e5b9c80caa8

[Yuki, 2017-04-10 13:55:13]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-04-10 14:04:17]

yukishiino@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[Yuki, 2017-04-10 14:04:17]

Could you guys review this CL?

Currently, WindowProxy::global_proxy_ is a strong reference to the global proxy.
 I'm planning to make global_proxy_ a weak reference once its frame is detached
from the DOM.

I think this is correct because, once the frame is detached from the DOM, user
agent does not need to make the context alive unless author script has a
reference to the context.

The weak reference should solve the issue that https://2713623002 is facing.

The name "DoNotDetachGlobal" does not explain well why it's okay to make it a
weak reference.  So I'd like to change the name in this CL.

[haraken, 2017-04-10 14:14:05]

LGTM

This CL is a preparation for making global_proxy_ weak, right?

[Yuki, 2017-04-10 14:18:30]

On 2017/04/10 14:14:05, haraken wrote:
> LGTM
> 
> This CL is a preparation for making global_proxy_ weak, right?

Yes, it is.  I think that |next_status == kFrameIsDetached| better explains why
it's good to make global_proxy_ weak.  For example,

"The frame is detached from the DOM tree, i.e., the frame is unreachable from
the DOM tree (it may be reachable from author script, though), so no need to
have a strong reference FROM THE DOM TREE to global_proxy_."

I'll send another CL to actually make it weak.

[Yuki, 2017-04-10 15:03:10]

The CQ bit was unchecked by yukishiino@chromium.org

[Yuki, 2017-04-10 15:03:18]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:03:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:37:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491836598516310, "parent_rev":
"62a00bb9b11365ad84681fbadeddf2cb528dbc81", "commit_rev":
"2bccabe644101b3215d4fc3d844e2e5b9c80caa8"}

[commit-bot: I haz the power, 2017-04-10 15:39:00]

Description was changed from

==========
v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

"Detach the global object OR NOT" doesn't matter much, or it does not
make a good sense.  "detach the global object OR context's frame was
detached from the DOM" makes much more sense.

This CL replaces GlobalDetachmentBehavior with Lifecycle, and
emphasizes the latter point.

BUG=
==========

to

==========
v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

"Detach the global object OR NOT" doesn't matter much, or it does not
make a good sense.  "detach the global object OR context's frame was
detached from the DOM" makes much more sense.

This CL replaces GlobalDetachmentBehavior with Lifecycle, and
emphasizes the latter point.

BUG=

Review-Url: https://codereview.chromium.org/2808093002
Cr-Commit-Position: refs/heads/master@{#463272}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bccabe644101b3215d4fc3d844e...
==========

[commit-bot: I haz the power, 2017-04-10 15:39:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bccabe644101b3215d4fc3d844e...

[dcheng, 2017-04-11 00:42:32]

lgtm