third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp - Issue 2808093002: v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2808093002: v8binding: Removes WindowProxy::GlobalDetachmentBehavior. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

index 350dfce327c3cc6971e8ba7e64535fba637adb3b..3689332d368b76c2f4e6f12fce1fd1fc9f2a01e6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

@@ -62,11 +62,11 @@ WindowProxy::WindowProxy(v8::Isolate* isolate,

lifecycle_(Lifecycle::kContextIsUninitialized) {}

void WindowProxy::ClearForClose() {

- DisposeContext(kDoNotDetachGlobal);

+ DisposeContext(Lifecycle::kFrameIsDetached);

}

void WindowProxy::ClearForNavigation() {

- DisposeContext(kDetachGlobal);

+ DisposeContext(Lifecycle::kGlobalObjectIsDetached);

}

v8::Local<v8::Object> WindowProxy::GlobalProxyIfNotDetached() {

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WindowProxy.h ('k') | no next file » | no next file with comments »