third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h - Issue 2808093002: v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2808093002: v8binding: Removes WindowProxy::GlobalDetachmentBehavior. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

index 6d1e096a124e575ddbaf51a2d4dda8547ad2f0df..98ef2b85115a903e439e53b7ece456c33e23fd4f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

+++ b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

@@ -55,7 +55,7 @@ class RemoteWindowProxy final : public WindowProxy {

RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>);

void Initialize() override;

- void DisposeContext(GlobalDetachmentBehavior) override;

+ void DisposeContext(Lifecycle next_status) override;

// Creates a new v8::Context with the window wrapper object as the global

// object (aka the inner global). Note that the window wrapper and its