third_party/WebKit/Source/bindings/core/v8/WindowProxy.h - Issue 2808093002: v8binding: Removes WindowProxy::GlobalDetachmentBehavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

Issue 2808093002: v8binding: Removes WindowProxy::GlobalDetachmentBehavior. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

index aeab230516960f8f34a7309f19e4bc7c67a390c0..816f3ad6ee62626310e722a0eb5fd7ec7526747e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

@@ -224,8 +224,7 @@ class WindowProxy : public GarbageCollectedFinalized<WindowProxy> {

virtual void Initialize() = 0;

- enum GlobalDetachmentBehavior { kDoNotDetachGlobal, kDetachGlobal };

- virtual void DisposeContext(GlobalDetachmentBehavior) = 0;

+ virtual void DisposeContext(Lifecycle next_status) = 0;

WARN_UNUSED_RESULT v8::Local<v8::Object> AssociateWithWrapper(

DOMWindow*,