Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2807713002: [Media Capabilities] Rename query() to decodingInfo() and MediaDecodingAbility to MediaCapabilities… (Closed)

Created:
3 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Capabilities] Rename query() to decodingInfo() and MediaDecodingAbility to MediaCapabilitiesInfo This is matching recent spec changes: https://github.com/WICG/media-capabilities/pull/31 The MediaConfiguration changes are not reflected in this CL. BUG=690380 R=mcasas@chromium.org,sandersd@chromium.org Review-Url: https://codereview.chromium.org/2807713002 Cr-Commit-Position: refs/heads/master@{#463403} Committed: https://chromium.googlesource.com/chromium/src/+/a147c6267bcb9c5321eb5e4db112a32199e92848

Patch Set 1 #

Patch Set 2 : rebase and fix webexposed tests #

Total comments: 1

Patch Set 3 : review comments & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -258 lines) Patch
M media/blink/webmediacapabilitiesclient_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediacapabilitiesclient_impl.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/media-capabilities/decodingInfo.html View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html View 1 chunk +0 lines, -85 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/media_capabilities/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/modules/media_capabilities/MediaCapabilitiesInfo.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_capabilities/MediaCapabilitiesInfo.cpp View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaCapabilitiesInfo.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.cpp View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.idl View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesClient.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
D third_party/WebKit/public/platform/modules/media_capabilities/WebMediaDecodingAbility.h View 1 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 33 (20 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 8 months ago (2017-04-07 18:26:13 UTC) #2
mlamouri (slow - plz ping)
-chcunningham@ +mcasas@ as Chris is out this week.
3 years, 8 months ago (2017-04-10 14:27:14 UTC) #11
mcasas
On 2017/04/10 14:27:14, mlamouri wrote: > -chcunningham@ +mcasas@ as Chris is out this week. lgtm ...
3 years, 8 months ago (2017-04-10 15:08:08 UTC) #12
mcasas
https://codereview.chromium.org/2807713002/diff/20001/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h File third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h (right): https://codereview.chromium.org/2807713002/diff/20001/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h#newcode13 third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h:13: // This is set by consumers and send back ...
3 years, 8 months ago (2017-04-10 15:20:47 UTC) #13
mlamouri (slow - plz ping)
All comments applied. Thank you for the quick review :)
3 years, 8 months ago (2017-04-10 19:20:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807713002/40001
3 years, 8 months ago (2017-04-10 19:21:28 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/407099)
3 years, 8 months ago (2017-04-10 19:34:29 UTC) #21
mlamouri (slow - plz ping)
+sandersd@ for media/blink/ rubberstamp
3 years, 8 months ago (2017-04-10 19:47:35 UTC) #23
sandersd (OOO until July 31)
media/ lgtm.
3 years, 8 months ago (2017-04-10 19:48:40 UTC) #25
sandersd (OOO until July 31)
Nit: Please fix typo in commit subject.
3 years, 8 months ago (2017-04-10 19:49:06 UTC) #26
mlamouri (slow - plz ping)
typo fixed
3 years, 8 months ago (2017-04-10 19:49:56 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807713002/40001
3 years, 8 months ago (2017-04-10 19:50:48 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:37:05 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a147c6267bcb9c5321eb5e4db112...

Powered by Google App Engine
This is Rietveld 408576698