Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2807663002: 📺 Move fullscreen web content to a new Activity. (Closed)

Created:
3 years, 8 months ago by PEConn
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn+watch_chromium.org, feature-media-reviews_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move fullscreen web content to a new Activity. Introduce the FullscreenMediaActivity and move Tabs to it when entering fullscreen and away from it when leaving fullscreen. BUG=709042 Review-Url: https://codereview.chromium.org/2807663002 Cr-Commit-Position: refs/heads/master@{#467705} Committed: https://chromium.googlesource.com/chromium/src/+/b71e98cdf14f18cb967a73857826f6e8c568cea0

Patch Set 1 #

Total comments: 9

Patch Set 2 : Addressed comments. #

Patch Set 3 : Updated Manifest with Activity rename. #

Patch Set 4 : Considered other ChromeActivity subclasses. #

Total comments: 9

Patch Set 5 : Added Test. #

Patch Set 6 : Added Test. #

Patch Set 7 : Fixed Hardware Acceleration Test. #

Patch Set 8 : Got code into committable state. #

Total comments: 9

Patch Set 9 : Cleaned manifest and made Intent logic clearer. #

Patch Set 10 : Fix test. #

Patch Set 11 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -27 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java View 1 2 3 4 5 6 7 8 1 chunk +107 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 1 2 3 4 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java View 1 2 3 4 5 6 7 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java View 7 chunks +13 lines, -19 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenWebContentsActivityTest.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +160 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 52 (34 generated)
PEConn
Please take a look, this is somewhere between rough and polished! I'm around in MTV ...
3 years, 8 months ago (2017-04-07 18:10:47 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/2807663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java File chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java (right): https://codereview.chromium.org/2807663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java#newcode17 chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java:17: * An Activity used to display fullscreen web contents. ...
3 years, 8 months ago (2017-04-07 20:08:59 UTC) #3
mlamouri (slow - plz ping)
Exciting to see this :) Let me know if there are specific areas you want ...
3 years, 8 months ago (2017-04-10 12:56:21 UTC) #4
Yusuf
https://codereview.chromium.org/2807663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java File chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java (right): https://codereview.chromium.org/2807663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java#newcode31 chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java:31: mTab.attachAndFinishReparenting(this, createTabDelegateFactory(), params); I don't think we need to ...
3 years, 8 months ago (2017-04-10 17:08:50 UTC) #5
PEConn
https://codereview.chromium.org/2807663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java File chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java (right): https://codereview.chromium.org/2807663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java#newcode17 chrome/android/java/src/org/chromium/chrome/browser/media/FullscreenMediaActivity.java:17: * An Activity used to display fullscreen web contents. ...
3 years, 8 months ago (2017-04-11 00:54:46 UTC) #7
Yusuf
per offline discussion this lgtm for tabbed activity tab reparenting logic. It will break for ...
3 years, 8 months ago (2017-04-12 00:15:14 UTC) #16
PEConn
I've added some complexity to fall back to the old fullscreen behaviour for CCTs and ...
3 years, 8 months ago (2017-04-12 20:56:24 UTC) #17
Theresa
https://codereview.chromium.org/2807663002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java File chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java (right): https://codereview.chromium.org/2807663002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java#newcode50 chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java:50: "org.chromium.chrome.browser.multiwindow.FromActivity"; Rather than introducing a new intent flag, I ...
3 years, 8 months ago (2017-04-12 22:29:12 UTC) #18
PEConn
https://codereview.chromium.org/2807663002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java File chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java (right): https://codereview.chromium.org/2807663002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java#newcode244 chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java:244: MultiWindowUtils.moveTabToActivity( On 2017/04/12 22:29:11, Theresa wrote: > Does the ...
3 years, 8 months ago (2017-04-13 14:45:57 UTC) #19
Theresa
https://codereview.chromium.org/2807663002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java File chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java (right): https://codereview.chromium.org/2807663002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java#newcode244 chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java:244: MultiWindowUtils.moveTabToActivity( On 2017/04/13 14:45:57, PEConn wrote: > On 2017/04/12 ...
3 years, 8 months ago (2017-04-13 15:22:09 UTC) #20
PEConn
So I've made a few changes: - Undid all of my changes to MultiwindowUtils. - ...
3 years, 8 months ago (2017-04-26 17:24:37 UTC) #29
Theresa
This seems much simpler. Looks good overall. https://codereview.chromium.org/2807663002/diff/140001/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2807663002/diff/140001/chrome/android/java/AndroidManifest.xml#newcode360 chrome/android/java/AndroidManifest.xml:360: <activity android:name="org.chromium.chrome.browser.FullscreenWebContentsActivity" ...
3 years, 8 months ago (2017-04-26 18:32:11 UTC) #30
PEConn
https://codereview.chromium.org/2807663002/diff/140001/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2807663002/diff/140001/chrome/android/java/AndroidManifest.xml#newcode360 chrome/android/java/AndroidManifest.xml:360: <activity android:name="org.chromium.chrome.browser.FullscreenWebContentsActivity" On 2017/04/26 18:32:11, Theresa wrote: > nit: ...
3 years, 7 months ago (2017-04-27 08:53:11 UTC) #31
Bernhard Bauer
Nice! LGTM if Theresa is happy.
3 years, 7 months ago (2017-04-27 14:04:34 UTC) #42
Theresa
lgtm https://codereview.chromium.org/2807663002/diff/140001/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java (right): https://codereview.chromium.org/2807663002/diff/140001/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java#newcode86 chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java:86: intent.addFlags(Intent.FLAG_ACTIVITY_MULTIPLE_TASK); On 2017/04/27 08:53:11, PEConn wrote: > On ...
3 years, 7 months ago (2017-04-27 15:32:25 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807663002/200001
3 years, 7 months ago (2017-04-27 15:48:50 UTC) #48
commit-bot: I haz the power
Committed patchset #11 (id:200001) as https://chromium.googlesource.com/chromium/src/+/b71e98cdf14f18cb967a73857826f6e8c568cea0
3 years, 7 months ago (2017-04-27 16:33:35 UTC) #51
findit-for-me
3 years, 7 months ago (2017-04-27 17:04:29 UTC) #52
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2849533004/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit(https://goo.gl/kROfz5) identified CL at revision 467705 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

Powered by Google App Engine
This is Rietveld 408576698