chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java - Issue 2807663002: 📺 Move fullscreen web content to a new Activity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

Issue 2807663002: 📺 Move fullscreen web content to a new Activity. (Closed)

Patch Set: Fix test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

index d9329ab9d11af5764b98d44ac14a32c6682428cb..cc20e9ba5a0984636ffece7503924a850c077354 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

@@ -18,7 +18,7 @@ import org.chromium.chrome.browser.tab.Tab;

public class SingleTabModel implements TabModel {

private final Activity mActivity;

- private final ObserverList<TabModelObserver> mObservers = new ObserverList<TabModelObserver>();

+ private final ObserverList<TabModelObserver> mObservers = new ObserverList<>();

private Tab mTab;

private boolean mIsIncognito;

@@ -173,7 +173,8 @@ public class SingleTabModel implements TabModel {

@Override

public void removeTab(Tab tab) {

- assert false;

+ mTab = null;

+ for (TabModelObserver obs : mObservers) obs.tabRemoved(tab);

}

@Override