Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2849533004: Revert of 📺 Move fullscreen web content to a new Activity. (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn+watch_chromium.org, feature-media-reviews_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https://codereview.chromium.org/2807663002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467705 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I3MWU5OGNkZjE0ZjE4Y2I5NjdhNzM4NTc4MjZmNmU4YzU2OGNlYTAM Original issue's description: > Move fullscreen web content to a new Activity. > > Introduce the FullscreenMediaActivity and move Tabs to it when entering > fullscreen and away from it when leaving fullscreen. > > BUG=709042 > > Review-Url: https://codereview.chromium.org/2807663002 > Cr-Commit-Position: refs/heads/master@{#467705} > Committed: https://chromium.googlesource.com/chromium/src/+/b71e98cdf14f18cb967a73857826f6e8c568cea0 TBR=mlamouri@chromium.org,bauerb@chromium.org,twellington@chromium.org,yusufo@chromium.org,peconn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709042 Review-Url: https://codereview.chromium.org/2849533004 Cr-Commit-Position: refs/heads/master@{#467716} Committed: https://chromium.googlesource.com/chromium/src/+/d0f88cff6e2cdbb91e95d28c66552a9d5035c5e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -335 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java View 1 chunk +0 lines, -107 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 4 chunks +2 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java View 8 chunks +20 lines, -14 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenWebContentsActivityTest.java View 1 chunk +0 lines, -160 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
findit-for-me
Created Revert of 📺 Move fullscreen web content to a new Activity.
3 years, 7 months ago (2017-04-27 17:04:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849533004/1
3 years, 7 months ago (2017-04-27 17:09:49 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-04-27 17:09:51 UTC) #5
zmin
lgtm
3 years, 7 months ago (2017-04-27 17:14:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849533004/1
3 years, 7 months ago (2017-04-27 17:15:41 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 17:16:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0f88cff6e2cdbb91e95d28c6655...

Powered by Google App Engine
This is Rietveld 408576698