chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java - Issue 2807663002: 📺 Move fullscreen web content to a new Activity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

Issue 2807663002: 📺 Move fullscreen web content to a new Activity. (Closed)

Patch Set: Fix test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

index 5d8debb9437b3e7b6e84e73365fd24c893813a16..a08d87ab9c4fd6b0c8c3b39a8a2c2a2a827245c7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

@@ -24,6 +24,8 @@ import org.chromium.base.annotations.CalledByNative;

import org.chromium.blink_public.platform.WebDisplayMode;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.AppHooks;

+import org.chromium.chrome.browser.ChromeFeatureList;

+import org.chromium.chrome.browser.FullscreenWebContentsActivity;

import org.chromium.chrome.browser.RepostFormWarningDialog;

import org.chromium.chrome.browser.document.DocumentUtils;

import org.chromium.chrome.browser.document.DocumentWebContentsDelegate;

@@ -215,8 +217,14 @@ public class TabWebContentsDelegateAndroid extends WebContentsDelegateAndroid {

@Override

public void toggleFullscreenModeForTab(boolean enableFullscreen) {

- if (!VideoPersister.getInstance().shouldDelayFullscreenModeChange(mTab, enableFullscreen)) {

- mTab.toggleFullscreenMode(enableFullscreen);

+ if (ChromeFeatureList.isEnabled(ChromeFeatureList.FULLSCREEN_ACTIVITY)

+ && mTab.getActivity().supportsFullscreenActivity()) {

+ FullscreenWebContentsActivity.toggleFullscreenMode(enableFullscreen, mTab);

+ } else {

+ if (!VideoPersister.getInstance().shouldDelayFullscreenModeChange(

+ mTab, enableFullscreen)) {

+ mTab.toggleFullscreenMode(enableFullscreen);

+ }

}