Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2807293002: VR: Rename ContentRectangle to UiElement (Closed)

Created:
3 years, 8 months ago by cjgrant
Modified:
3 years, 8 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, acondor_
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Rename ContentRectangle to UiElement UiElements show arbitrary textures now, not just content. Generalize the naming to avoid confusion. BUG=710150 Review-Url: https://codereview.chromium.org/2807293002 Cr-Commit-Position: refs/heads/master@{#464033} Committed: https://chromium.googlesource.com/chromium/src/+/d871a9338a39d46cbb25ee6571a4e225f049bda1

Patch Set 1 #

Patch Set 2 : Rebase; rename unit test file; formatting. #

Patch Set 3 : Rebase onto Michael's landed GVR types CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -649 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/vr_shell/ui_element.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/android/vr_shell/ui_element.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/android/vr_shell/ui_element_unittest.cc View 1 10 chunks +10 lines, -10 lines 0 comments Download
D chrome/browser/android/vr_shell/ui_elements.h View 1 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/browser/android/vr_shell/ui_elements.cc View 1 1 chunk +0 lines, -212 lines 0 comments Download
D chrome/browser/android/vr_shell/ui_elements_unittest.cc View 1 1 chunk +0 lines, -177 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 1 14 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_unittest.cc View 1 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 6 chunks +10 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
cjgrant
3 years, 8 months ago (2017-04-10 20:35:23 UTC) #2
mthiesse
lgtm As discussed offline, please add a TODO somewhere to fix our inheritance tree so ...
3 years, 8 months ago (2017-04-11 20:49:03 UTC) #3
cjgrant
On 2017/04/11 20:49:03, mthiesse wrote: > lgtm > > As discussed offline, please add a ...
3 years, 8 months ago (2017-04-11 20:51:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807293002/40001
3 years, 8 months ago (2017-04-11 21:04:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807293002/40001
3 years, 8 months ago (2017-04-12 14:21:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 15:32:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d871a9338a39d46cbb25ee6571a4...

Powered by Google App Engine
This is Rietveld 408576698