Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2809143004: VR: Add a native UI element scene manager (Closed)

Created:
3 years, 8 months ago by cjgrant
Modified:
3 years, 8 months ago
Reviewers:
acondor_, mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, acondor_
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Add a native UI element scene manager - Mirror the concept of the HTML scene manager in native. - Temporarily let both the HTML UI and native code manage elements. - Future CLs will supply native-driven WebVR security warnings. BUG=710150 Review-Url: https://codereview.chromium.org/2809143004 Cr-Commit-Position: refs/heads/master@{#464078} Committed: https://chromium.googlesource.com/chromium/src/+/e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -20 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/ui_scene_manager.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
cjgrant
https://codereview.chromium.org/2809143004/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2809143004/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode307 chrome/browser/android/vr_shell/vr_shell.cc:307: PostToGlThreadWhenReady(base::Bind(&UiSceneManager::SetWebVRMode, This is what clang-format does; not how I ...
3 years, 8 months ago (2017-04-11 14:54:30 UTC) #2
acondor_
lgtm
3 years, 8 months ago (2017-04-11 16:06:50 UTC) #4
mthiesse
lgtm
3 years, 8 months ago (2017-04-11 20:11:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809143004/20001
3 years, 8 months ago (2017-04-12 16:26:20 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 17:54:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e4b2c606f4fcdfc6d535165bef73...

Powered by Google App Engine
This is Rietveld 408576698