Fix menu sizing for data saver footer.

Fix menu sizing for data saver footer.

First off, the footer sizing has been broken because setMenuHeight
was not adding the footer size to the max available space.

Secondly, this hides the data saver footer if the screen size is
under 240dp (differs from the spec of 230dp as that resulted in
a menu with 2.5 options based on the menu padding and logic to
hide the last of the half row if not enough space).

BUG=708332
Review-Url: https://codereview.chromium.org/2807123003
Cr-Commit-Position: refs/heads/master@{#463429}
Committed: https://chromium.googlesource.com/chromium/src/+/fb2bf86d665fddf7e580cb67f6be8f3c182188b7

[Ted C, 2017-04-10 21:53:49]

tedchoc@chromium.org changed reviewers:
+ megjablon@chromium.org, twellington@chromium.org

[Ted C, 2017-04-10 21:53:49]

twellington - PTAL
megjablon - FYI

[Theresa, 2017-04-10 21:58:24]

lgtm

[Ted C, 2017-04-10 22:01:14]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-04-10 22:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2807123003/#ps20001
(title: "Fix strictmode violation when showing data reduction promo")

[commit-bot: I haz the power, 2017-04-10 22:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 22:48:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491861674205200,
"parent_rev": "5e671fffc45441c5dd3458871a8aa8f4a3f2e632", "commit_rev":
"fb2bf86d665fddf7e580cb67f6be8f3c182188b7"}

[commit-bot: I haz the power, 2017-04-10 22:48:52]

Description was changed from

==========
Fix menu sizing for data saver footer.

First off, the footer sizing has been broken because setMenuHeight
was not adding the footer size to the max available space.

Secondly, this hides the data saver footer if the screen size is
under 240dp (differs from the spec of 230dp as that resulted in
a menu with 2.5 options based on the menu padding and logic to
hide the last of the half row if not enough space).

BUG=708332
==========

to

==========
Fix menu sizing for data saver footer.

First off, the footer sizing has been broken because setMenuHeight
was not adding the footer size to the max available space.

Secondly, this hides the data saver footer if the screen size is
under 240dp (differs from the spec of 230dp as that resulted in
a menu with 2.5 options based on the menu padding and logic to
hide the last of the half row if not enough space).

BUG=708332

Review-Url: https://codereview.chromium.org/2807123003
Cr-Commit-Position: refs/heads/master@{#463429}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb2bf86d665fddf7e580cb67f6be...
==========

[commit-bot: I haz the power, 2017-04-10 22:48:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb2bf86d665fddf7e580cb67f6be...