chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java - Issue 2807123003: Fix menu sizing for data saver footer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 2807123003: Fix menu sizing for data saver footer. (Closed)

Patch Set: Fix strictmode violation when showing data reduction promo Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

index 44dac630a8e578ca4650527d26a09e716ca656a2..a0e8e2ec75c67925afa81c2656a35d886a7bff11 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

@@ -398,6 +398,8 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {

// Fade out the last item if we cannot fit all items.

if (numCanFit < numMenuItems) {

int spaceForFullItems = numCanFit * (mItemRowHeight + mItemDividerHeight);

+ spaceForFullItems += footerHeight;

int spaceForPartialItem = (int) (LAST_ITEM_SHOW_FRACTION * mItemRowHeight);

// Determine which item needs hiding.

if (spaceForFullItems + spaceForPartialItem < availableScreenSpace) {