Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

Issue 2807123003: Fix menu sizing for data saver footer. (Closed)
Patch Set: Fix strictmode violation when showing data reduction promo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
index 29078598fb9c1cb2b837ea9a283d6e2e7bfa8cea..554288307e577e2f56a4b67292435d92e828c49e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
@@ -136,8 +136,13 @@ public class AppMenuHandler {
}
Point pt = new Point();
mActivity.getWindowManager().getDefaultDisplay().getSize(pt);
- mAppMenu.show(wrapper, anchorView, isByPermanentButton,
- rotation, appRect, pt.y, mDelegate.getFooterResourceId());
+
+ int footerResourceId = 0;
+ if (mDelegate.shouldShowFooter(appRect.height())) {
+ footerResourceId = mDelegate.getFooterResourceId();
+ }
+ mAppMenu.show(wrapper, anchorView, isByPermanentButton, rotation, appRect, pt.y,
+ footerResourceId);
mAppMenuDragHelper.onShow(startDragging);
RecordUserAction.record("MobileMenuShow");
return true;

Powered by Google App Engine
This is Rietveld 408576698