chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2807123003: Fix menu sizing for data saver footer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2807123003: Fix menu sizing for data saver footer. (Closed)

Patch Set: Fix strictmode violation when showing data reduction promo Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index e62268a64df8432b13096265bb960f39eab1b2f3..05a4d78b023438861f5dbcfb4246013fb7c8b037 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -307,6 +307,15 @@ public class AppMenuPropertiesDelegate {

}

/**

+ * Determines whether the header should be shown based on the maximum available menu height.

+ * @param maxMenuHeight The maximum available height for the menu to draw.

+ * @return Whether the footer, as specified in {@link #getFooterResourceId()}, should be shown.

+ */

+ public boolean shouldShowFooter(int maxMenuHeight) {

+ return true;

+ }

+ /**

* Updates the bookmarks bridge.

* @param bookmarkBridge The bookmarks bridge.