Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm

Issue 2806323003: [ObjC ARC] Converts ios/chrome/browser/ui/settings:unit_tests to ARC. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm
index 9059fe26d2fe3bdf146e3ae32104d714f0e95d37..8d11bc0816ec2911fa9c7464c2f5e831dc63cfe2 100644
--- a/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm
@@ -6,7 +6,6 @@
#include "base/compiler_specific.h"
#include "base/logging.h"
-#import "base/mac/scoped_nsobject.h"
#include "ios/chrome/browser/chrome_url_constants.h"
#import "ios/chrome/browser/ui/collection_view/collection_view_controller_test.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
@@ -16,6 +15,10 @@
#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
// An AboutChromeTableViewController that intercepts calls to
// |chromeExecuteCommand:| in order to test the commands.
@interface TestAboutChromeCollectionViewController
@@ -27,12 +30,12 @@
@end
@implementation TestAboutChromeCollectionViewController {
- base::scoped_nsobject<OpenUrlCommand> command_;
+ OpenUrlCommand* command_;
}
- (IBAction)chromeExecuteCommand:(id)sender {
DCHECK([sender isKindOfClass:[OpenUrlCommand class]]);
- command_.reset([static_cast<OpenUrlCommand*>(sender) retain]);
+ command_ = static_cast<OpenUrlCommand*>(sender);
}
- (OpenUrlCommand*)command {
@@ -46,7 +49,7 @@ namespace {
class AboutChromeCollectionViewControllerTest
: public CollectionViewControllerTest {
public:
- CollectionViewController* NewController() override NS_RETURNS_RETAINED {
+ CollectionViewController* InstantiateController() override {
return [[TestAboutChromeCollectionViewController alloc] init];
}
};

Powered by Google App Engine
This is Rietveld 408576698