Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2796043002: [ObjC ARC] Converts ios/chrome/browser/ui/settings:eg_tests to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/settings:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2796043002 Cr-Commit-Position: refs/heads/master@{#463999} Committed: https://chromium.googlesource.com/chromium/src/+/4faf6a64037e14070bd243ceb964ac682e96808d

Patch Set 1 #

Patch Set 2 : s/unsafe/weak #

Messages

Total messages: 15 (10 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-11 16:31:40 UTC) #8
lpromero
lgtm
3 years, 8 months ago (2017-04-12 11:07:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796043002/20001
3 years, 8 months ago (2017-04-12 11:07:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4faf6a64037e14070bd243ceb964ac682e96808d
3 years, 8 months ago (2017-04-12 12:06:19 UTC) #14
stkhapugin
3 years, 8 months ago (2017-04-12 14:26:34 UTC) #15
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698