Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method

Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method

As a first step of ASSERT removal from modules/webaudio, this CL
removes all DCHECK_IS_ON() condition check from isGraphOwner() and put
the check inside of the method.

The method is only used inside of DCHECK() so it must be no-op in the
release build. That is why it returns false, so we can catch the
anomaly when it happens.

BUG=707643
Review-Url: https://codereview.chromium.org/2805823003
Cr-Commit-Position: refs/heads/master@{#462940}
Committed: https://chromium.googlesource.com/chromium/src/+/5041c078af8f65707d859754396d887d780a7e04

[hongchan, 2017-04-07 17:03:57]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-04-07 17:03:58]

PTAL.

[Raymond Toy, 2017-04-07 17:11:01]

lgtm with nit

https://codereview.chromium.org/2805823003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp (right):

https://codereview.chromium.org/2805823003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp:72: return
false;
Add comment why false and not true.

[hongchan, 2017-04-07 17:25:55]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-04-07 17:25:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2805823003/#ps20001
(title: "Added comment")

[commit-bot: I haz the power, 2017-04-07 17:26:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:47:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491585955260910,
"parent_rev": "f045f6dffa8407f8ff9cd18437c6557affadbda7", "commit_rev":
"5041c078af8f65707d859754396d887d780a7e04"}

[commit-bot: I haz the power, 2017-04-07 18:47:57]

Description was changed from

==========
Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method

As a first step of ASSERT removal from modules/webaudio, this CL
removes all DCHECK_IS_ON() condition check from isGraphOwner() and put
the check inside of the method.

The method is only used inside of DCHECK() so it must be no-op in the
release build. That is why it returns false, so we can catch the
anomaly when it happens.

BUG=707643
==========

to

==========
Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method

As a first step of ASSERT removal from modules/webaudio, this CL
removes all DCHECK_IS_ON() condition check from isGraphOwner() and put
the check inside of the method.

The method is only used inside of DCHECK() so it must be no-op in the
release build. That is why it returns false, so we can catch the
anomaly when it happens.

BUG=707643

Review-Url: https://codereview.chromium.org/2805823003
Cr-Commit-Position: refs/heads/master@{#462940}
Committed:
https://chromium.googlesource.com/chromium/src/+/5041c078af8f65707d859754396d...
==========

[commit-bot: I haz the power, 2017-04-07 18:47:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5041c078af8f65707d859754396d...