Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

Issue 2805823003: Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method (Closed)
Patch Set: Added comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 // channcelCountMode must be 'clamped-max'. 198 // channcelCountMode must be 'clamped-max'.
199 if (mode != "clamped-max") { 199 if (mode != "clamped-max") {
200 exceptionState.throwDOMException( 200 exceptionState.throwDOMException(
201 NotSupportedError, 201 NotSupportedError,
202 "ConvolverNode: channelCountMode cannot be changed from 'clamped-max'"); 202 "ConvolverNode: channelCountMode cannot be changed from 'clamped-max'");
203 } 203 }
204 } 204 }
205 205
206 void ConvolverHandler::checkNumberOfChannelsForInput(AudioNodeInput* input) { 206 void ConvolverHandler::checkNumberOfChannelsForInput(AudioNodeInput* input) {
207 DCHECK(context()->isAudioThread()); 207 DCHECK(context()->isAudioThread());
208 #if DCHECK_IS_ON()
209 DCHECK(context()->isGraphOwner()); 208 DCHECK(context()->isGraphOwner());
210 #endif
211 209
212 DCHECK(input); 210 DCHECK(input);
213 DCHECK_EQ(input, &this->input(0)); 211 DCHECK_EQ(input, &this->input(0));
214 if (input != &this->input(0)) 212 if (input != &this->input(0))
215 return; 213 return;
216 214
217 if (m_buffer) { 215 if (m_buffer) {
218 unsigned numberOfChannels = input->numberOfChannels(); 216 unsigned numberOfChannels = input->numberOfChannels();
219 unsigned numberOfReverbeChannels = m_buffer->numberOfChannels(); 217 unsigned numberOfReverbeChannels = m_buffer->numberOfChannels();
220 unsigned numberOfOutputChannels = 218 unsigned numberOfOutputChannels =
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 286
289 bool ConvolverNode::normalize() const { 287 bool ConvolverNode::normalize() const {
290 return convolverHandler().normalize(); 288 return convolverHandler().normalize();
291 } 289 }
292 290
293 void ConvolverNode::setNormalize(bool normalize) { 291 void ConvolverNode::setNormalize(bool normalize) {
294 convolverHandler().setNormalize(normalize); 292 convolverHandler().setNormalize(normalize);
295 } 293 }
296 294
297 } // namespace blink 295 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698