Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

Issue 2805823003: Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method (Closed)
Patch Set: Added comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 } else { 134 } else {
135 exceptionState.throwDOMException( 135 exceptionState.throwDOMException(
136 IndexSizeError, 136 IndexSizeError,
137 ExceptionMessages::indexOutsideRange( 137 ExceptionMessages::indexOutsideRange(
138 "smoothing value", k, 0.0, ExceptionMessages::InclusiveBound, 1.0, 138 "smoothing value", k, 0.0, ExceptionMessages::InclusiveBound, 1.0,
139 ExceptionMessages::InclusiveBound)); 139 ExceptionMessages::InclusiveBound));
140 } 140 }
141 } 141 }
142 142
143 void AnalyserHandler::updatePullStatus() { 143 void AnalyserHandler::updatePullStatus() {
144 #if DCHECK_IS_ON()
145 DCHECK(context()->isGraphOwner()); 144 DCHECK(context()->isGraphOwner());
146 #endif
147 145
148 if (output(0).isConnected()) { 146 if (output(0).isConnected()) {
149 // When an AudioBasicInspectorNode is connected to a downstream node, it 147 // When an AudioBasicInspectorNode is connected to a downstream node, it
150 // will get pulled by the downstream node, thus remove it from the context's 148 // will get pulled by the downstream node, thus remove it from the context's
151 // automatic pull list. 149 // automatic pull list.
152 if (m_needAutomaticPull) { 150 if (m_needAutomaticPull) {
153 context()->deferredTaskHandler().removeAutomaticPullNode(this); 151 context()->deferredTaskHandler().removeAutomaticPullNode(this);
154 m_needAutomaticPull = false; 152 m_needAutomaticPull = false;
155 } 153 }
156 } else { 154 } else {
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 270
273 void AnalyserNode::getFloatTimeDomainData(DOMFloat32Array* array) { 271 void AnalyserNode::getFloatTimeDomainData(DOMFloat32Array* array) {
274 analyserHandler().getFloatTimeDomainData(array); 272 analyserHandler().getFloatTimeDomainData(array);
275 } 273 }
276 274
277 void AnalyserNode::getByteTimeDomainData(DOMUint8Array* array) { 275 void AnalyserNode::getByteTimeDomainData(DOMUint8Array* array) {
278 analyserHandler().getByteTimeDomainData(array); 276 analyserHandler().getByteTimeDomainData(array);
279 } 277 }
280 278
281 } // namespace blink 279 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698