third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp - Issue 2805823003: Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

Issue 2805823003: Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method (Closed)

Patch Set: Added comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

index 71ef965c70af23634ad076be84ce2933168fdf9a..c5f42dd97c6709888a1db1e3b745bca9178c063b 100644

--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

@@ -205,9 +205,7 @@ void ConvolverHandler::setChannelCountMode(const String& mode,

void ConvolverHandler::checkNumberOfChannelsForInput(AudioNodeInput* input) {

DCHECK(context()->isAudioThread());

-#if DCHECK_IS_ON()

DCHECK(context()->isGraphOwner());

-#endif

DCHECK(input);

DCHECK_EQ(input, &this->input(0));