Revert of [reland] Do not block in SimpleThread::Start().

Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of https://codereview.chromium.org/2801073005/ )

Reason for revert:
Speculatively reverting hoping to resolve lots of random failures on 2 bots, starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24574

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/40019

Original issue's description:
> [reland] Do not block in SimpleThread::Start().
> 
> This CL is identical to https://codereview.chromium.org/2664953004.
> The race condition that it highlighted in a TaskScheduler test the
> first time that it landed was fixed by
> https://codereview.chromium.org/2798373002/
> 
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
> 
> BUG=
> TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2801073005
> Cr-Commit-Position: refs/heads/master@{#462912}
> Committed: https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b566ceb5d3441

TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2804393002
Cr-Commit-Position: refs/heads/master@{#462998}
Committed: https://chromium.googlesource.com/chromium/src/+/6710dbd5124741db004176153c87c609435e7788

[Łukasz Anforowicz, 2017-04-07 20:48:19]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-04-07 20:48:20]

Created Revert of [reland] Do not block in SimpleThread::Start().

[commit-bot: I haz the power, 2017-04-07 20:48:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:58:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491598099847510, "parent_rev":
"c4ba106074379b272a5a33bde847ec1db40383bf", "commit_rev":
"6710dbd5124741db004176153c87c609435e7788"}

[commit-bot: I haz the power, 2017-04-07 20:59:00]

Description was changed from

==========
Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of
https://codereview.chromium.org/2801073005/ )

Reason for revert:
Speculatively reverting hoping to resolve lots of random failures on 2 bots,
starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...

Original issue's description:
> [reland] Do not block in SimpleThread::Start().
> 
> This CL is identical to https://codereview.chromium.org/2664953004.
> The race condition that it highlighted in a TaskScheduler test the
> first time that it landed was fixed by
> https://codereview.chromium.org/2798373002/
> 
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
> 
> BUG=
> TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2801073005
> Cr-Commit-Position: refs/heads/master@{#462912}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b...

TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of
https://codereview.chromium.org/2801073005/ )

Reason for revert:
Speculatively reverting hoping to resolve lots of random failures on 2 bots,
starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...

Original issue's description:
> [reland] Do not block in SimpleThread::Start().
> 
> This CL is identical to https://codereview.chromium.org/2664953004.
> The race condition that it highlighted in a TaskScheduler test the
> first time that it landed was fixed by
> https://codereview.chromium.org/2798373002/
> 
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
> 
> BUG=
> TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2801073005
> Cr-Commit-Position: refs/heads/master@{#462912}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b...

TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2804393002
Cr-Commit-Position: refs/heads/master@{#462998}
Committed:
https://chromium.googlesource.com/chromium/src/+/6710dbd5124741db004176153c87...
==========

[commit-bot: I haz the power, 2017-04-07 20:59:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6710dbd5124741db004176153c87...

[Charlie Reis, 2017-04-07 23:45:19]

Thanks for reverting, lukasza@!  This did turn all 3 of the bots below green:
Linux Tests (dbg)(1)(32)
Linux Tests (dbg)(1)
Linux ChromiumOS Tests (dbg)(1)

A large number of random tests on these bots had been timing out before the
revert, across the following steps:
content_browsertests
extensions_browsertests
interactive_ui_tests
sync_integration_tests
browser_tests

fdoray@: I don't see a bug associated with any of these CLs or reverts.  Can you
file one before attempting to land it again?  It's useful to have a central
place to keep track of info like this.  Thanks!

[henrika (OOO until Aug 14), 2017-04-18 14:05:02]

Description was changed from

==========
Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of
https://codereview.chromium.org/2801073005/ )

Reason for revert:
Speculatively reverting hoping to resolve lots of random failures on 2 bots,
starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...

Original issue's description:
> [reland] Do not block in SimpleThread::Start().
> 
> This CL is identical to https://codereview.chromium.org/2664953004.
> The race condition that it highlighted in a TaskScheduler test the
> first time that it landed was fixed by
> https://codereview.chromium.org/2798373002/
> 
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
> 
> BUG=
> TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2801073005
> Cr-Commit-Position: refs/heads/master@{#462912}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b...

TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2804393002
Cr-Commit-Position: refs/heads/master@{#462998}
Committed:
https://chromium.googlesource.com/chromium/src/+/6710dbd5124741db004176153c87...
==========

to

==========
Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of
https://codereview.chromium.org/2801073005/ )

Reason for revert:
Speculatively reverting hoping to resolve lots of random failures on 2 bots,
starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...

Original issue's description:
> [reland] Do not block in SimpleThread::Start().
> 
> This CL is identical to https://codereview.chromium.org/2664953004.
> The race condition that it highlighted in a TaskScheduler test the
> first time that it landed was fixed by
> https://codereview.chromium.org/2798373002/
> 
> There is no good reason to block in SimpleThread::Start().
> In addition to introducing unnecessary latency, blocking in
> Start() prevents a non-joinable DelegateSimpleThread from
> being deleted from Run() without external synchronization
> (it is wrong to delete SimpleThread while Start() is waiting
> on the |event_| member).
> 
> BUG=
> TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Review-Url: https://codereview.chromium.org/2801073005
> Cr-Commit-Position: refs/heads/master@{#462912}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b...

TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2804393002
Cr-Commit-Position: refs/heads/master@{#462998}
Committed:
https://chromium.googlesource.com/chromium/src/+/6710dbd5124741db004176153c87...
==========

[henrika (OOO until Aug 14), 2017-04-18 14:05:02]

henrika@chromium.org changed reviewers:
- henrika@chromium.org