[reland] Do not block in SimpleThread::Start().

[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801073005
Cr-Commit-Position: refs/heads/master@{#462912}
Committed: https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b566ceb5d3441

[fdoray, 2017-04-07 12:26:28]

Description was changed from

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fdoray, 2017-04-07 12:27:37]

Description was changed from

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fdoray, 2017-04-07 12:27:37]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, henrika@chromium.org, jam@chromium.org

[fdoray, 2017-04-07 12:27:42]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 12:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-07 12:39:51]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-04-07 12:39:55]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-04-07 12:40:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 16:22:25]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[fdoray, 2017-04-07 17:22:45]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:23:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-07 17:24:28]

Description was changed from

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fdoray, 2017-04-07 17:24:35]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-04-07 17:24:37]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-04-07 17:24:41]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:38:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491585881538440, "parent_rev":
"edcb0318305f99c32bffaf206997b961f7898e1c", "commit_rev":
"d5acadb2d99dfbbde0cbe251173b566ceb5d3441"}

[commit-bot: I haz the power, 2017-04-07 17:39:22]

Description was changed from

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[reland] Do not block in SimpleThread::Start().

This CL is identical to https://codereview.chromium.org/2664953004.
The race condition that it highlighted in a TaskScheduler test the
first time that it landed was fixed by
https://codereview.chromium.org/2798373002/

There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).

BUG=
TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801073005
Cr-Commit-Position: refs/heads/master@{#462912}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b...
==========

[commit-bot: I haz the power, 2017-04-07 17:39:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b...

[Łukasz Anforowicz, 2017-04-07 20:48:19]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2804393002/ by lukasza@chromium.org.

The reason for reverting is: Speculatively reverting hoping to resolve lots of
random failures on 2 bots, starting with the builds below:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%....

[Łukasz Anforowicz, 2017-04-07 22:42:03]

It seems that the speculative worked / that the test failures were indeed caused
by this CL - in the current build [the one that includes the revert - (*)]
browser_tests are all green (and there were random failures in the last) 3
builds).

(*)
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...