Revert of [snapshot] Move builtins generation into mksnapshot

Revert of [snapshot] Move builtins generation into mksnapshot (patchset #8 id:160001 of https://codereview.chromium.org/2760233005/ )

Reason for revert:
I think that this CL breaks chromium compilation on windows with clang (). All other CLs in the list looks trivial and don't change test/unittest/BUILD.gn.

[42456/47924] CXX obj/v8/test/unittests/unittests/value-serializer-unittest.obj
[42457/47924] LINK unittests.exe unittests.exe.pdb
FAILED: unittests.exe unittests.exe.pdb 
E:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./unittests.exe /PDB:./unittests.exe.pdb @./unittests.exe.rsp
bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::Add(class v8::internal::AllocationObserver * const &,class v8::internal::FreeStoreAllocationPolicy)" (?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z) referenced in function "public: virtual void __cdecl v8::internal::Space::AddAllocationObserver(class v8::internal::AllocationObserver *)" (?AddAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::Add(class v8::internal::AllocationObserver * const &,class v8::internal::FreeStoreAllocationPolicy)" (?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)

bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: bool __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class v8::internal::AllocationObserver * const &)" (?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z) referenced in function "public: virtual void __cdecl v8::internal::Space::RemoveAllocationObserver(class v8::internal::AllocationObserver *)" (?RemoveAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: bool __cdecl v8::internal::List<class v8::internal::AllocationObserver *,class v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class v8::internal::AllocationObserver * const &)" (?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)

./unittests.exe : fatal error LNK1120: 2 unresolved externals

Original issue's description:
> [snapshot] Move builtins generation into mksnapshot
> 
> and out of the main library. This saves about 5% of binary size
> (800KB on x64, 373KB on android_arm).
> 
> Only the GN build is supported; the GYP build is maintained working
> but does not support the feature.
> 
> BUG=v8:6055
> CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
> 
> Review-Url: https://codereview.chromium.org/2760233005
> Cr-Commit-Position: refs/heads/master@{#44412}
> Committed: https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a0e966

TBR=jgruber@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6055
Review-Url: https://codereview.chromium.org/2803903002
Cr-Commit-Position: refs/heads/master@{#44422}
Committed: https://chromium.googlesource.com/v8/v8/+/ba9fc3d7bcecf58490d449e9f0129c079498b2ad

[kozy, 2017-04-05 23:41:34]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-04-05 23:41:34]

Created Revert of [snapshot] Move builtins generation into mksnapshot

[commit-bot: I haz the power, 2017-04-05 23:41:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:41:58]

Failed to apply patch for src/v8.gyp:
While running git apply --index -3 -p1;
  error: patch failed: src/v8.gyp:492
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: src/v8.gyp: patch does not apply

Patch:       src/v8.gyp
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index
8dcfd1144ab875c69e17d38e9b0d190eab0ecb9b..1ae7e522dd2b47845a771142c039c0812fcddb2d
100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -492,7 +492,6 @@
         'builtins/builtins-boolean.cc',
         'builtins/builtins-boolean-gen.cc',
         'builtins/builtins-call.cc',
-        'builtins/builtins-call-gen.cc',
         'builtins/builtins-callsite.cc',
         'builtins/builtins-constructor-gen.cc',
         'builtins/builtins-constructor-gen.h',
@@ -517,7 +516,6 @@
         'builtins/builtins-internal.cc',
         'builtins/builtins-internal-gen.cc',
         'builtins/builtins-interpreter.cc',
-        'builtins/builtins-interpreter-gen.cc',
         'builtins/builtins-json.cc',
         'builtins/builtins-math.cc',
         'builtins/builtins-math-gen.cc',
@@ -546,7 +544,6 @@
         'builtins/builtins-wasm-gen.cc',
         'builtins/builtins.cc',
         'builtins/builtins.h',
-        'builtins/setup-builtins-internal.cc',
         'cached-powers.cc',
         'cached-powers.h',
         'callable.h',
@@ -1077,8 +1074,6 @@
         'interpreter/interpreter-intrinsics.h',
         'interpreter/interpreter-intrinsics-generator.cc',
         'interpreter/interpreter-intrinsics-generator.h',
-        'interpreter/setup-interpreter.h',
-        'interpreter/setup-interpreter-internal.cc',
         'isolate-inl.h',
         'isolate.cc',
         'isolate.h',
@@ -1263,8 +1258,6 @@
         'runtime/runtime.h',
         'safepoint-table.cc',
         'safepoint-table.h',
-        'setup-isolate.h',
-        'setup-isolate-full.cc',
         'signature.h',
         'simulator.h',
         'small-pointer-list.h',

[kozy, 2017-04-05 23:52:58]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:53:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:53:12]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1491436378860440,
"parent_rev": "f0c7bbec618df7143ac9611b990e670ac9921e50", "commit_rev":
"ba9fc3d7bcecf58490d449e9f0129c079498b2ad"}

[commit-bot: I haz the power, 2017-04-05 23:53:20]

Description was changed from

==========
Revert of [snapshot] Move builtins generation into mksnapshot (patchset #8
id:160001 of https://codereview.chromium.org/2760233005/ )

Reason for revert:
I think that this CL breaks chromium compilation on windows with clang (). All
other CLs in the list looks trivial and don't change test/unittest/BUILD.gn.

[42456/47924] CXX obj/v8/test/unittests/unittests/value-serializer-unittest.obj
[42457/47924] LINK unittests.exe unittests.exe.pdb
FAILED: unittests.exe unittests.exe.pdb 
E:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
link.exe /nologo /OUT:./unittests.exe /PDB:./unittests.exe.pdb
@./unittests.exe.rsp
bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: void
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::Add(class
v8::internal::AllocationObserver * const &,class
v8::internal::FreeStoreAllocationPolicy)"
(?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)
referenced in function "public: virtual void __cdecl
v8::internal::Space::AddAllocationObserver(class
v8::internal::AllocationObserver *)"
(?AddAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: void
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::Add(class
v8::internal::AllocationObserver * const &,class
v8::internal::FreeStoreAllocationPolicy)"
(?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)

bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: bool
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class
v8::internal::AllocationObserver * const &)"
(?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)
referenced in function "public: virtual void __cdecl
v8::internal::Space::RemoveAllocationObserver(class
v8::internal::AllocationObserver *)"
(?RemoveAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: bool
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class
v8::internal::AllocationObserver * const &)"
(?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)

./unittests.exe : fatal error LNK1120: 2 unresolved externals

Original issue's description:
> [snapshot] Move builtins generation into mksnapshot
> 
> and out of the main library. This saves about 5% of binary size
> (800KB on x64, 373KB on android_arm).
> 
> Only the GN build is supported; the GYP build is maintained working
> but does not support the feature.
> 
> BUG=v8:6055
> CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
> 
> Review-Url: https://codereview.chromium.org/2760233005
> Cr-Commit-Position: refs/heads/master@{#44412}
> Committed:
https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a...

TBR=jgruber@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,jkumme...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6055
==========

to

==========
Revert of [snapshot] Move builtins generation into mksnapshot (patchset #8
id:160001 of https://codereview.chromium.org/2760233005/ )

Reason for revert:
I think that this CL breaks chromium compilation on windows with clang (). All
other CLs in the list looks trivial and don't change test/unittest/BUILD.gn.

[42456/47924] CXX obj/v8/test/unittests/unittests/value-serializer-unittest.obj
[42457/47924] LINK unittests.exe unittests.exe.pdb
FAILED: unittests.exe unittests.exe.pdb 
E:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
link.exe /nologo /OUT:./unittests.exe /PDB:./unittests.exe.pdb
@./unittests.exe.rsp
bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: void
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::Add(class
v8::internal::AllocationObserver * const &,class
v8::internal::FreeStoreAllocationPolicy)"
(?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)
referenced in function "public: virtual void __cdecl
v8::internal::Space::AddAllocationObserver(class
v8::internal::AllocationObserver *)"
(?AddAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: void
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::Add(class
v8::internal::AllocationObserver * const &,class
v8::internal::FreeStoreAllocationPolicy)"
(?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)

bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: bool
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class
v8::internal::AllocationObserver * const &)"
(?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)
referenced in function "public: virtual void __cdecl
v8::internal::Space::RemoveAllocationObserver(class
v8::internal::AllocationObserver *)"
(?RemoveAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: bool
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class
v8::internal::AllocationObserver * const &)"
(?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)

./unittests.exe : fatal error LNK1120: 2 unresolved externals

Original issue's description:
> [snapshot] Move builtins generation into mksnapshot
> 
> and out of the main library. This saves about 5% of binary size
> (800KB on x64, 373KB on android_arm).
> 
> Only the GN build is supported; the GYP build is maintained working
> but does not support the feature.
> 
> BUG=v8:6055
> CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
> 
> Review-Url: https://codereview.chromium.org/2760233005
> Cr-Commit-Position: refs/heads/master@{#44412}
> Committed:
https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a...

TBR=jgruber@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,jkumme...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6055

Review-Url: https://codereview.chromium.org/2803903002
Cr-Commit-Position: refs/heads/master@{#44422}
Committed:
https://chromium.googlesource.com/v8/v8/+/ba9fc3d7bcecf58490d449e9f0129c07949...
==========

[commit-bot: I haz the power, 2017-04-05 23:53:21]

Committed patchset #2 (id:290001) as
https://chromium.googlesource.com/v8/v8/+/ba9fc3d7bcecf58490d449e9f0129c07949...