Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/builtins/builtins.h

Issue 2803903002: Revert of [snapshot] Move builtins generation into mksnapshot (Closed)
Patch Set: rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/builtins/builtins.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins.h
diff --git a/src/builtins/builtins.h b/src/builtins/builtins.h
index e3976f253849ed2056a6fbe6645133f7f4fffc94..b6946588552590bdab05951e1ef66442e7d17c4d 100644
--- a/src/builtins/builtins.h
+++ b/src/builtins/builtins.h
@@ -28,6 +28,9 @@ class Builtins {
public:
~Builtins();
+ // Generate all builtin code objects. Should be called once during
+ // isolate initialization.
+ void SetUp(Isolate* isolate, bool create_heap_objects);
void TearDown();
// Garbage collection support.
@@ -104,11 +107,6 @@ class Builtins {
private:
Builtins();
- // Used by SetupIsolateDelegate.
- void MarkInitialized() {
- DCHECK(!initialized_);
- initialized_ = true;
- }
static void Generate_CallFunction(MacroAssembler* masm,
ConvertReceiverMode mode,
@@ -147,7 +145,6 @@ class Builtins {
bool initialized_;
friend class Isolate;
- friend class SetupIsolateDelegate;
DISALLOW_COPY_AND_ASSIGN(Builtins);
};
« no previous file with comments | « src/api.cc ('k') | src/builtins/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698