Revert of [snapshot] Move builtins generation into mksnapshot

src/builtins/builtins.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_H_
 #define V8_BUILTINS_BUILTINS_H_
 
 #include "src/base/flags.h"
 #include "src/builtins/builtins-definitions.h"
 #include "src/globals.h"
@@ skipping 10 matching lines @@
 class ObjectVisitor;
 enum class InterpreterPushArgsMode : unsigned;
 namespace compiler {
 class CodeAssemblerState;
 }
 
 class Builtins {
  public:
   ~Builtins();
 
+  // Generate all builtin code objects. Should be called once during
+  // isolate initialization.
+  void SetUp(Isolate* isolate, bool create_heap_objects);
   void TearDown();
 
   // Garbage collection support.
   void IterateBuiltins(ObjectVisitor* v);
 
   // Disassembler support.
   const char* Lookup(byte* pc);
 
   enum Name : int32_t {
 #define DEF_ENUM(Name, ...) k##Name,
@@ skipping 56 matching lines @@
   enum ExitFrameType { EXIT, BUILTIN_EXIT };
 
   static void Generate_Adaptor(MacroAssembler* masm, Address builtin_address,
                                ExitFrameType exit_frame_type);
 
   static bool AllowDynamicFunction(Isolate* isolate, Handle<JSFunction> target,
                                    Handle<JSObject> target_global_proxy);
 
  private:
   Builtins();
-  // Used by SetupIsolateDelegate.
-  void MarkInitialized() {
-    DCHECK(!initialized_);
-    initialized_ = true;
-  }
 
   static void Generate_CallFunction(MacroAssembler* masm,
                                     ConvertReceiverMode mode,
                                     TailCallMode tail_call_mode);
 
   static void Generate_CallBoundFunctionImpl(MacroAssembler* masm,
                                              TailCallMode tail_call_mode);
 
   static void Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode,
                             TailCallMode tail_call_mode);
@@ skipping 18 matching lines @@
 #undef DECLARE_ASM
 #undef DECLARE_TF
 
   // Note: These are always Code objects, but to conform with
   // IterateBuiltins() above which assumes Object**'s for the callback
   // function f, we use an Object* array here.
   Object* builtins_[builtin_count];
   bool initialized_;
 
   friend class Isolate;
-  friend class SetupIsolateDelegate;
 
   DISALLOW_COPY_AND_ASSIGN(Builtins);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_H_