[snapshot] Move builtins generation into mksnapshot

Reland "[snapshot] Move builtins generation into mksnapshot"

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

Previously landed as 4782bc0df89 / r44412.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;

Review-Url: https://codereview.chromium.org/2760233005
Cr-Commit-Position: refs/heads/master@{#44489}
Committed: https://chromium.googlesource.com/v8/v8/+/5f9af1e7b56846950f134a198d150822e75337b6

[Jakob Kummerow, 2017-03-21 16:37:59]

jkummerow@chromium.org changed reviewers:
+ jgruber@chromium.org, rmcilroy@chromium.org

[Jakob Kummerow, 2017-03-21 16:38:00]

Ross, PTAL @ interpreter.
Jakob, PTAL @ everything else.

Find some reviewer's guidance below.

https://codereview.chromium.org/2760233005/diff/1/src/builtins/builtins-call.cc
File src/builtins/builtins-call.cc (left):

https://codereview.chromium.org/2760233005/diff/1/src/builtins/builtins-call....
src/builtins/builtins-call.cc:81: void
Builtins::Generate_CallFunction_ReceiverIsNullOrUndefined(
Forgot to split this out before.

https://codereview.chromium.org/2760233005/diff/1/src/builtins/builtins-inter...
File src/builtins/builtins-interpreter.cc (left):

https://codereview.chromium.org/2760233005/diff/1/src/builtins/builtins-inter...
src/builtins/builtins-interpreter.cc:35: void
Builtins::Generate_InterpreterPushArgsAndCall(MacroAssembler* masm) {
Forgot to split this out before.

https://codereview.chromium.org/2760233005/diff/1/src/builtins/builtins.cc
File src/builtins/builtins.cc (left):

https://codereview.chromium.org/2760233005/diff/1/src/builtins/builtins.cc#ol...
src/builtins/builtins.cc:31: namespace {
all this stuff moved to setup-builtins-internal.cc

https://codereview.chromium.org/2760233005/diff/1/src/builtins/setup-builtins...
File src/builtins/setup-builtins-internal.cc (right):

https://codereview.chromium.org/2760233005/diff/1/src/builtins/setup-builtins...
src/builtins/setup-builtins-internal.cc:112: void
SetupBuiltinsDelegate::AddBuiltin(Builtins* builtins, int index,
This function (and its call sites below) is new; the rest in this file is moved
over from builtins.cc.

https://codereview.chromium.org/2760233005/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (left):

https://codereview.chromium.org/2760233005/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:78: void Interpreter::Initialize() {
This moved to setup-interpreter-full.cc.

https://codereview.chromium.org/2760233005/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2760233005/diff/1/src/isolate.h#newcode1422
src/isolate.h:1422: SetupBuiltinsDelegate* setup_builtins_delegate_;
The only reason we need this Delegate is so that the TestIsolate class can
inject an alternative implementation to customize startup.

https://codereview.chromium.org/2760233005/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2760233005/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:56: 'setup-builtins-deserialize.cc',
Pacify the presubmit check that produces an error when a source file was not
added to any .gyp file.

[rmcilroy, 2017-03-21 16:55:56]

https://codereview.chromium.org/2760233005/diff/1/src/interpreter/setup-inter...
File src/interpreter/setup-interpreter-full.cc (right):

https://codereview.chromium.org/2760233005/diff/1/src/interpreter/setup-inter...
src/interpreter/setup-interpreter-full.cc:26: }
This code needs to be done for snapshot builds as well if the flag is enabled.

At a high-level, I'm not keen on having the Interpreter class implemented across
multiple file. Could you do Interpreter::Internalize() back to interpreter.cc
and move the code which generates and installs the bytecode handlers into
IntepreterGenerator?

[Michael Achenbach, 2017-03-21 20:07:11]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-03-21 20:07:11]

https://codereview.chromium.org/2760233005/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2760233005/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:56: 'setup-builtins-deserialize.cc',
On 2017/03/21 16:38:00, Jakob Kummerow wrote:
> Pacify the presubmit check that produces an error when a source file was not
> added to any .gyp file.

Ack.

[jgruber, 2017-03-22 09:21:30]

Very cool, lgtm

[Jakob Kummerow, 2017-03-27 17:19:26]

Patchset #2 (id:20001) has been deleted

[Jakob Kummerow, 2017-03-28 10:35:16]

PTAL.

https://codereview.chromium.org/2760233005/diff/1/src/interpreter/setup-inter...
File src/interpreter/setup-interpreter-full.cc (right):

https://codereview.chromium.org/2760233005/diff/1/src/interpreter/setup-inter...
src/interpreter/setup-interpreter-full.cc:26: }
On 2017/03/21 16:55:56, rmcilroy wrote:
> This code needs to be done for snapshot builds as well if the flag is enabled.
> 
> At a high-level, I'm not keen on having the Interpreter class implemented
across
> multiple file. Could you do Interpreter::Internalize() back to interpreter.cc
> and move the code which generates and installs the bytecode handlers into
> IntepreterGenerator?

Done.
As it turns out, cctests/test-serialize requires going through a Delegate, just
like for builtins.

[Michael Achenbach, 2017-03-28 12:17:12]

Description was changed from

==========
[snapshot] Move builtins generation into mksnapshot

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

BUG=v8:6055
==========

to

==========
[snapshot] Move builtins generation into mksnapshot

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
==========

[Michael Achenbach, 2017-03-28 12:19:57]

lgtm on build and tools changes. I added a nosnap bot to CL desc to make sure
that works.

[rmcilroy, 2017-03-29 17:11:44]

LGTM, thanks.

[Jakob Kummerow, 2017-03-29 18:13:52]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-03-29 18:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2760233005/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-03-29 18:14:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 18:15:34]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23544)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/23571)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38007)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Jakob Kummerow, 2017-04-04 11:49:01]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 11:49:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 11:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 11:55:54]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Jakob Kummerow, 2017-04-04 15:34:18]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 15:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 16:21:44]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/23783)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Jakob Kummerow, 2017-04-05 12:28:18]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 12:28:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-05 12:39:51]

On 2017/03/29 18:15:34, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
>   v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
>   v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23544)
>   v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
>   v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
>   v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
>   v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/23571)
>   v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
>   v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
>   v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38007)
>   v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

Nice. I like the way this is split up using the delegate. LGTM.

[commit-bot: I haz the power, 2017-04-05 13:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 13:16:49]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2017-04-05 13:27:04]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-04-05 13:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
jgruber@chromium.org, rmcilroy@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2760233005/#ps160001
(title: "nosnap: skip incompatible tests")

[commit-bot: I haz the power, 2017-04-05 13:27:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 13:28:49]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1491398824951530,
"parent_rev": "4f8b76068da0d167103d2cf2d88117c2f5dc6dcf", "commit_rev":
"4782bc0df89ceb127e38017b8dcf531222a0e966"}

[commit-bot: I haz the power, 2017-04-05 13:28:56]

Description was changed from

==========
[snapshot] Move builtins generation into mksnapshot

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
==========

to

==========
[snapshot] Move builtins generation into mksnapshot

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;

Review-Url: https://codereview.chromium.org/2760233005
Cr-Commit-Position: refs/heads/master@{#44412}
Committed:
https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a...
==========

[commit-bot: I haz the power, 2017-04-05 13:28:57]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a...

[kozy, 2017-04-05 23:41:33]

A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/2803903002/ by kozyatinskiy@chromium.org.

The reason for reverting is: I think that this CL breaks chromium compilation on
windows with clang (). All other CLs in the list looks trivial and don't change
test/unittest/BUILD.gn.

[42456/47924] CXX obj/v8/test/unittests/unittests/value-serializer-unittest.obj
[42457/47924] LINK unittests.exe unittests.exe.pdb
FAILED: unittests.exe unittests.exe.pdb 
E:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
link.exe /nologo /OUT:./unittests.exe /PDB:./unittests.exe.pdb
@./unittests.exe.rsp
bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: void
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::Add(class
v8::internal::AllocationObserver * const &,class
v8::internal::FreeStoreAllocationPolicy)"
(?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)
referenced in function "public: virtual void __cdecl
v8::internal::Space::AddAllocationObserver(class
v8::internal::AllocationObserver *)"
(?AddAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: void
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::Add(class
v8::internal::AllocationObserver * const &,class
v8::internal::FreeStoreAllocationPolicy)"
(?Add@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAAXAEBQEAVAllocationObserver@23@VFreeStoreAllocationPolicy@23@@Z)

bitmap-unittest.obj : error LNK2019: unresolved external symbol "public: bool
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class
v8::internal::AllocationObserver * const &)"
(?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)
referenced in function "public: virtual void __cdecl
v8::internal::Space::RemoveAllocationObserver(class
v8::internal::AllocationObserver *)"
(?RemoveAllocationObserver@Space@internal@v8@@UEAAXPEAVAllocationObserver@23@@Z)

slot-set-unittest.obj : error LNK2001: unresolved external symbol "public: bool
__cdecl v8::internal::List<class v8::internal::AllocationObserver *,class
v8::internal::FreeStoreAllocationPolicy>::RemoveElement(class
v8::internal::AllocationObserver * const &)"
(?RemoveElement@?$List@PEAVAllocationObserver@internal@v8@@VFreeStoreAllocationPolicy@23@@internal@v8@@QEAA_NAEBQEAVAllocationObserver@23@@Z)

./unittests.exe : fatal error LNK1120: 2 unresolved externals.

[Michael Achenbach, 2017-04-06 08:46:24]

FYI: This seems to also lead to failures on the legacy gyp full debug bot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20full%20debug...

Greenified after the revert.

[Jakob Kummerow, 2017-04-07 11:52:26]

Description was changed from

==========
[snapshot] Move builtins generation into mksnapshot

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;

Review-Url: https://codereview.chromium.org/2760233005
Cr-Commit-Position: refs/heads/master@{#44412}
Committed:
https://chromium.googlesource.com/v8/v8/+/4782bc0df89ceb127e38017b8dcf531222a...
==========

to

==========
Reland "[snapshot] Move builtins generation into mksnapshot"

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

Previously landed as 4782bc0df89 / r44412.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
==========

[Jakob Kummerow, 2017-04-07 12:12:51]

The Windows+clang failure is fixed by
https://codereview.chromium.org/2806493002/

The GYP failure is fixed by patch set 10.

Relanding.

[Jakob Kummerow, 2017-04-07 12:13:28]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 12:13:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 13:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:04:49]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2017-04-07 13:16:48]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-04-07 13:16:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jgruber@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2760233005/#ps200001
(title: "fix GYP builds")

[commit-bot: I haz the power, 2017-04-07 13:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 13:31:30]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1491571008030400,
"parent_rev": "084471ce6bf76410caf6e51c0fc21f0277cf0fa0", "commit_rev":
"5f9af1e7b56846950f134a198d150822e75337b6"}

[commit-bot: I haz the power, 2017-04-07 13:31:35]

Description was changed from

==========
Reland "[snapshot] Move builtins generation into mksnapshot"

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

Previously landed as 4782bc0df89 / r44412.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;
==========

to

==========
Reland "[snapshot] Move builtins generation into mksnapshot"

and out of the main library. This saves about 5% of binary size
(800KB on x64, 373KB on android_arm).

Only the GN build is supported; the GYP build is maintained working
but does not support the feature.

Previously landed as 4782bc0df89 / r44412.

BUG=v8:6055
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_nosnap_rel;

Review-Url: https://codereview.chromium.org/2760233005
Cr-Commit-Position: refs/heads/master@{#44489}
Committed:
https://chromium.googlesource.com/v8/v8/+/5f9af1e7b56846950f134a198d150822e75...
==========

[commit-bot: I haz the power, 2017-04-07 13:31:36]

Committed patchset #10 (id:200001) as
https://chromium.googlesource.com/v8/v8/+/5f9af1e7b56846950f134a198d150822e75...