Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2802773002: Pick surface lifetime type with arg. (Closed)

Created:
3 years, 8 months ago by kylechar
Modified:
3 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pick surface lifetime type with arg. Add arg to MojoFrameSinkManager to pick surface lifetime type. BUG=664547 Review-Url: https://codereview.chromium.org/2802773002 Cr-Commit-Position: refs/heads/master@{#462846} Committed: https://chromium.googlesource.com/chromium/src/+/3f07d979d8161ed82181c1cd89eef17214df78bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M components/viz/frame_sinks/mojo_frame_sink_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/viz/frame_sinks/mojo_frame_sink_manager.cc View 1 chunk +4 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
kylechar
MojoFrameSinkManager constructor takes a bool because I didn't want to add new DEP on cc/surfaces ...
3 years, 8 months ago (2017-04-05 17:45:10 UTC) #2
Fady Samuel
lgtm
3 years, 8 months ago (2017-04-05 17:51:19 UTC) #3
Fady Samuel
lgtm lgtm
3 years, 8 months ago (2017-04-05 17:51:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802773002/1
3 years, 8 months ago (2017-04-07 13:24:43 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 13:31:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f07d979d8161ed82181c1cd89ee...

Powered by Google App Engine
This is Rietveld 408576698