Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2803993003: Introduce FrameSinkManagerHost in content/browser/. (Closed)

Created:
3 years, 8 months ago by kylechar
Modified:
3 years, 8 months ago
Reviewers:
Fady Samuel, piman
CC:
chromium-reviews, creis+watch_chromium.org, Ian Vollick, nasko+codewatch_chromium.org, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, Saman Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce FrameSinkManagerHost in content/browser/. FrameSinkManagerHost is an object that will live in the browser process and manage CompositorFrameSinks. The browser process accesses SurfaceManager directly to do this now. The goal is eliminate all direct access to SurfaceManager and move it to another process. FrameSinkManagerHost owns MojoFrameSinkManager in the short term but still uses Mojo to access it. The only impact of this change is the ownership of SurfaceManager is moved. Subsequent CLs can start using FrameSinkManagerHost to manage CompositorFrameSinks and eliminate direct access to SurfaceManager. BUG=657959, 664547 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2803993003 Cr-Commit-Position: refs/heads/master@{#463448} Committed: https://chromium.googlesource.com/chromium/src/+/69bd9163b311213bb181832c104e4cab2c2e12b7

Patch Set 1 #

Patch Set 2 : Move change entirely to content/browser/. #

Patch Set 3 : Fix android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -7 lines) Patch
M content/browser/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/compositor/frame_sink_manager_host.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A content/browser/compositor/frame_sink_manager_host.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 4 chunks +9 lines, -4 lines 0 comments Download
M content/browser/compositor/image_transport_factory.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/compositor/surface_utils.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/compositor/surface_utils.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
kylechar
piman/fsamuel: Let me know what you think of this? piman: OWNERS approvals too.
3 years, 8 months ago (2017-04-10 19:21:36 UTC) #12
Fady Samuel
lgtm. This seems reasonable to me. The intent would be individual views: ui::Compositor RenderWidgetHostView etc ...
3 years, 8 months ago (2017-04-10 19:27:29 UTC) #13
piman
lgtm
3 years, 8 months ago (2017-04-10 19:59:58 UTC) #14
kylechar
Thanks!
3 years, 8 months ago (2017-04-10 23:36:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803993003/40001
3 years, 8 months ago (2017-04-10 23:37:13 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 23:46:52 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/69bd9163b311213bb181832c104e...

Powered by Google App Engine
This is Rietveld 408576698