Create //components/viz/frame_sinks and move code.

Create //components/viz/frame_sinks and move code.

Move all of the existing code for what used to be called
DisplayCompositor and is now MojoFrameSinkManager from various places to
a single target under src/components/viz/. This is the chunk of code that
both mus and non-mus will use to implement the FrameSinkManager
interface.

BUG=664547
Review-Url: https://codereview.chromium.org/2795823003
Cr-Commit-Position: refs/heads/master@{#462633}
Committed: https://chromium.googlesource.com/chromium/src/+/3cf0cf68b3930de4aaac19a00ed8b8f0fd0e6ee3

[kylechar, 2017-04-04 15:29:17]

Description was changed from

==========
Create components/viz/frame_sinks and move code.

Move all of the existing code for what used to be called
DisplayCompositor and is now MojoFrameSinkManager from various places to
a single target under components/viz/. This is the chunk of code that
both mus and non-mus will use to implement the FrameSinkManager
interface.

BUG=664547
==========

to

==========
Create //components/viz/frame_sinks and move code.

Move all of the existing code for what used to be called
DisplayCompositor and is now MojoFrameSinkManager from various places to
a single target under src/components/viz/. This is the chunk of code that
both mus and non-mus will use to implement the FrameSinkManager
interface.

BUG=664547
==========

[kylechar, 2017-04-04 16:41:41]

kylechar@chromium.org changed reviewers:
+ danakj@chromium.org, piman@chromium.org, rockot@chromium.org

[kylechar, 2017-04-04 16:41:41]

danakj: Basically everything. This is the same CL as
https://codereview.chromium.org/2768563002/ essentially, just a slightly
different location and rebased on other changes.
piman: DEPS "+gpu"
rockot: DEPS +"mojo/public"

[danakj, 2017-04-04 17:24:35]

Can you have a look at cc/PRESUBMIT.py and take as much as makes sense (all?) to
components/viz/ ?

https://codereview.chromium.org/2795823003/diff/20001/components/viz/DEPS
File components/viz/DEPS (right):

https://codereview.chromium.org/2795823003/diff/20001/components/viz/DEPS#new...
components/viz/DEPS:2: "+cc",
I think it might be helpful to not have all of cc/ here, and instead have
subdirs of cc/ in the DEPS of subdirs of viz/. That might help point out any
weird layering, since cc is a mix of layer and display compositor and frame
sinky things.

[piman, 2017-04-04 17:24:43]

lgtm

[danakj, 2017-04-04 17:26:04]

Can you also add a components/viz/OWNERS?

[kylechar, 2017-04-05 15:31:35]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org, yzshen@chromium.org
- rockot@chromium.org

[kylechar, 2017-04-05 15:31:35]

danakj: I fixed the DEPS thing. The other changes should be done a separate CL
since they're not specific to making a //components/viz/frame_sinks target.

+fsamuel FYI

-rockot, +yzshen for DEPS "+mojo/public"

https://codereview.chromium.org/2795823003/diff/20001/components/viz/DEPS
File components/viz/DEPS (right):

https://codereview.chromium.org/2795823003/diff/20001/components/viz/DEPS#new...
components/viz/DEPS:2: "+cc",
On 2017/04/04 17:24:35, danakj wrote:
> I think it might be helpful to not have all of cc/ here, and instead have
> subdirs of cc/ in the DEPS of subdirs of viz/. That might help point out any
> weird layering, since cc is a mix of layer and display compositor and frame
> sinky things.

Done.

[Fady Samuel, 2017-04-05 15:32:59]

lgtm

[Fady Samuel, 2017-04-05 15:33:51]

Please add danakj@ as OWNER to components/viz.

[kylechar, 2017-04-05 15:37:11]

On 2017/04/05 15:33:51, Fady Samuel wrote:
> Please add danakj@ as OWNER to components/viz.

Working on a separate CL for components/viz/OWNERS and
components/viz/PRESUBMIT.py change.

[danakj, 2017-04-05 15:45:27]

On Wed, Apr 5, 2017 at 11:33 AM, <fsamuel@chromium.org> wrote:

> Please add danakj@ as OWNER to components/viz.
>

I'm okay with being in there but I don't want to be the entire bus factor
:) I was thinking we could pull over any relevant cc/ owners maybe? Looking
in there: enne,danakj,vmpstr,piman,jbauman all seem like relevant reviewers.

I think we should put an OWNERS file in this CL, either in viz/ or in
viz/frame_sinks/, so the files don't become unowned. I'm okay with pulling
over the PRESUBMIT in another change, as it might require some changes to
make the current files clean wrt the PRESUBMIT rules.




>
> https://codereview.chromium.org/2795823003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[kylechar, 2017-04-06 15:03:24]

danakj: I think all the changes you wanted are done?

[danakj, 2017-04-06 18:23:06]

Yep LGTM

[kylechar, 2017-04-06 19:22:05]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 19:22:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-04-06 20:10:12]

lgtm

[yzshen1, 2017-04-06 20:10:28]

On 2017/04/06 20:10:12, yzshen1 wrote:
> lgtm

(For mojo/public DEPS)

[commit-bot: I haz the power, 2017-04-06 20:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 20:35:00]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-04-06 20:35:21]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-04-06 20:35:21]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2795823003/#ps40001
(title: "Fix DEPS.")

[commit-bot: I haz the power, 2017-04-06 20:36:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:47:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491510921327510,
"parent_rev": "46aa9d9db9c0581937a96ced13747039fffe943c", "commit_rev":
"3cf0cf68b3930de4aaac19a00ed8b8f0fd0e6ee3"}

[commit-bot: I haz the power, 2017-04-06 21:48:12]

Description was changed from

==========
Create //components/viz/frame_sinks and move code.

Move all of the existing code for what used to be called
DisplayCompositor and is now MojoFrameSinkManager from various places to
a single target under src/components/viz/. This is the chunk of code that
both mus and non-mus will use to implement the FrameSinkManager
interface.

BUG=664547
==========

to

==========
Create //components/viz/frame_sinks and move code.

Move all of the existing code for what used to be called
DisplayCompositor and is now MojoFrameSinkManager from various places to
a single target under src/components/viz/. This is the chunk of code that
both mus and non-mus will use to implement the FrameSinkManager
interface.

BUG=664547

Review-Url: https://codereview.chromium.org/2795823003
Cr-Commit-Position: refs/heads/master@{#462633}
Committed:
https://chromium.googlesource.com/chromium/src/+/3cf0cf68b3930de4aaac19a00ed8...
==========

[commit-bot: I haz the power, 2017-04-06 21:48:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3cf0cf68b3930de4aaac19a00ed8...