Revert ANGLE rolls back to fe48632

Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill,geofflang,piman

Review-Url: https://codereview.chromium.org/2802613006 .
Cr-Commit-Position: refs/heads/master@{#462718}
Committed: https://chromium.googlesource.com/chromium/src/+/fbddb8a0804da8393a4cbe74f91ceba8dd7524a8

[hans, 2017-04-06 21:52:46]

Description was changed from

==========
Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
==========

to

==========
Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hans, 2017-04-06 21:54:59]

Description was changed from

==========
Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill,geofflang,piman
==========

[hans, 2017-04-06 21:54:59]

hans@chromium.org changed reviewers:
+ geofflang@chromium.org, jmadill@chromium.org, piman@chromium.org,
thakis@chromium.org

[hans, 2017-04-06 21:55:08]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:56:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 00:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 00:37:34]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[hans, 2017-04-07 00:50:48]

Description was changed from

==========
Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill,geofflang,piman
==========

to

==========
Revert ANGLE rolls back to fe48632

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill,geofflang,piman

Review-Url: https://codereview.chromium.org/2802613006 .
Cr-Commit-Position: refs/heads/master@{#462718}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbddb8a0804da8393a4cbe74f91c...
==========

[hans, 2017-04-07 00:50:49]

Committed patchset #1 (id:1) manually as
fbddb8a0804da8393a4cbe74f91ceba8dd7524a8 (presubmit successful).

[Ken Russell (switch to Gerrit), 2017-04-07 18:38:51]

On 2017/04/07 00:50:49, hans wrote:
> Committed patchset #1 (id:1) manually as
> fbddb8a0804da8393a4cbe74f91ceba8dd7524a8 (presubmit successful).

Hans, it's not reasonable to forcibly land patches like this when tryservers are
failing. It looks like this caused http://crbug.com/709342 , which is blocking
the V8 and other teams from rolling since it introduced a reliable failure on
linux_optional_gpu_tests_rel.

[hans, 2017-04-07 18:41:17]

On 2017/04/07 18:38:51, Ken Russell wrote:
> On 2017/04/07 00:50:49, hans wrote:
> > Committed patchset #1 (id:1) manually as
> > fbddb8a0804da8393a4cbe74f91ceba8dd7524a8 (presubmit successful).
> 
> Hans, it's not reasonable to forcibly land patches like this when tryservers
are
> failing. It looks like this caused http://crbug.com/709342 , which is blocking
> the V8 and other teams from rolling since it introduced a reliable failure on
> linux_optional_gpu_tests_rel.

My change is a revert, the intention was not to introduce anything. The trybot
failed with "TEST RESULTS WERE INVALID", so I assumed it was an infrastructure
problem.

[Jamie Madill, 2017-04-07 18:42:05]

On 2017/04/07 18:38:51, Ken Russell wrote:
> On 2017/04/07 00:50:49, hans wrote:
> > Committed patchset #1 (id:1) manually as
> > fbddb8a0804da8393a4cbe74f91ceba8dd7524a8 (presubmit successful).
> 
> Hans, it's not reasonable to forcibly land patches like this when tryservers
are
> failing. It looks like this caused http://crbug.com/709342 , which is blocking
> the V8 and other teams from rolling since it introduced a reliable failure on
> linux_optional_gpu_tests_rel.

FYI, Geoff landed a fix (just disable Vulkan again), so we can roll forward
ANGLE. Not sure if we've kicked one today.

[Jamie Madill, 2017-04-07 18:43:37]

On 2017/04/07 18:42:05, Jamie Madill wrote:
> On 2017/04/07 18:38:51, Ken Russell wrote:
> > On 2017/04/07 00:50:49, hans wrote:
> > > Committed patchset #1 (id:1) manually as
> > > fbddb8a0804da8393a4cbe74f91ceba8dd7524a8 (presubmit successful).
> > 
> > Hans, it's not reasonable to forcibly land patches like this when tryservers
> are
> > failing. It looks like this caused http://crbug.com/709342 , which is
blocking
> > the V8 and other teams from rolling since it introduced a reliable failure
on
> > linux_optional_gpu_tests_rel.
> 
> FYI, Geoff landed a fix (just disable Vulkan again), so we can roll forward
> ANGLE. Not sure if we've kicked one today.

Was part of https://codereview.chromium.org/2787123002/