Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2801813004: Refactor VerifyCertificateChain test data to include a key purpose (Closed)

Created:
3 years, 8 months ago by eroman
Modified:
3 years, 8 months ago
Reviewers:
mattm
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor VerifyCertificateChain test data to include a key purpose parameter. BUG=634442 Review-Url: https://codereview.chromium.org/2801813004 Cr-Commit-Position: refs/heads/master@{#463055} Committed: https://chromium.googlesource.com/chromium/src/+/594aac0a801ab81711785cffcf101c6ec1e33723

Patch Set 1 #

Patch Set 2 : checkpoint #

Total comments: 2

Patch Set 3 : Address mattm's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6201 lines, -5911 lines) Patch
M net/cert/internal/path_builder_unittest.cc View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M net/cert/internal/path_builder_verify_certificate_chain_unittest.cc View 1 2 1 chunk +8 lines, -12 lines 0 comments Download
M net/cert/internal/test_helpers.h View 1 2 1 chunk +24 lines, -8 lines 0 comments Download
M net/cert/internal/test_helpers.cc View 1 2 6 chunks +30 lines, -15 lines 0 comments Download
M net/cert/internal/trust_store_collection_unittest.cc View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M net/cert/internal/trust_store_nss_unittest.cc View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_typed_unittest.h View 1 2 1 chunk +3 lines, -9 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_unittest.cc View 1 2 1 chunk +6 lines, -10 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/basic-constraints-pathlen-0-self-issued.pem View 1 2 9 chunks +202 lines, -197 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/common.py View 1 2 3 chunks +11 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/constrained-non-self-signed-root.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/constrained-root-basic-constraints-ca-false.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/constrained-root-lacks-basic-constraints.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-constrained-root.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-intermediate.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-target.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-target-notBefore.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-unconstrained-root.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-basic-constraints-pathlen-0-self-issued.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-constrained-non-self-signed-root.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-constrained-root-basic-constraints-ca-false.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-constrained-root-lacks-basic-constraints.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-constrained-root.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-intermediate.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-target.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-unconstrained-root.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-incorrect-trust-anchor.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-basic-constraints-ca-false.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-basic-constraints-not-critical.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-signing-key-usage.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-signed-with-md5.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-unknown-critical-extension.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-unknown-non-critical-extension.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-key-rollover.py View 1 2 1 chunk +11 lines, -7 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-non-self-signed-root.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-and-intermediate.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-has-pathlen-but-not-ca.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-not-end-entity.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-using-ecdsa.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-with-md5.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-wrong-signature.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-unconstrained-non-self-signed-root.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-unconstrained-root-basic-constraints-ca-false.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-unconstrained-root-lacks-basic-constraints.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-violates-basic-constraints-pathlen-0.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-constrained-root.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-unconstrained-root.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/incorrect-trust-anchor.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-ca-false.pem View 1 2 7 chunks +155 lines, -150 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-not-critical.pem View 1 2 7 chunks +155 lines, -150 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-signed-with-md5.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-unknown-critical-extension.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-unknown-non-critical-extension.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/issuer-and-subject-not-byte-for-byte-equal.pem View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/issuer-and-subject-not-byte-for-byte-equal-anchor.pem View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-longrolloverchain.pem View 1 2 11 chunks +254 lines, -249 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-newchain.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-oldchain.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-rolloverchain.pem View 1 2 9 chunks +204 lines, -199 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/non-self-signed-root.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/rebase-errors.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/target-and-intermediate.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-not-end-entity.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem View 1 2 7 chunks +122 lines, -117 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-using-ecdsa.pem View 1 2 7 chunks +128 lines, -123 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-unknown-critical-extension.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-wrong-signature.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unconstrained-non-self-signed-root.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unconstrained-root-basic-constraints-ca-false.pem View 1 2 7 chunks +154 lines, -149 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unconstrained-root-lacks-basic-constraints.pem View 1 2 7 chunks +153 lines, -148 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-basic-constraints-pathlen-0.pem View 1 2 9 chunks +202 lines, -197 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-pathlen-1-constrained-root.pem View 1 2 9 chunks +202 lines, -197 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-pathlen-1-unconstrained-root.pem View 1 2 9 chunks +202 lines, -197 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
eroman
3 years, 8 months ago (2017-04-06 04:32:56 UTC) #8
mattm
lgtm https://codereview.chromium.org/2801813004/diff/10001/net/cert/internal/path_builder_unittest.cc File net/cert/internal/path_builder_unittest.cc (right): https://codereview.chromium.org/2801813004/diff/10001/net/cert/internal/path_builder_unittest.cc#newcode449 net/cert/internal/path_builder_unittest.cc:449: time_ = test.time; doesn't need to set oldroot_ ...
3 years, 8 months ago (2017-04-06 20:29:34 UTC) #9
eroman
https://codereview.chromium.org/2801813004/diff/10001/net/cert/internal/path_builder_unittest.cc File net/cert/internal/path_builder_unittest.cc (right): https://codereview.chromium.org/2801813004/diff/10001/net/cert/internal/path_builder_unittest.cc#newcode449 net/cert/internal/path_builder_unittest.cc:449: time_ = test.time; On 2017/04/06 20:29:34, mattm wrote: > ...
3 years, 8 months ago (2017-04-07 21:41:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801813004/20001
3 years, 8 months ago (2017-04-07 21:42:20 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:52:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/594aac0a801ab81711785cffcf10...

Powered by Google App Engine
This is Rietveld 408576698