net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py - Issue 2801813004: Refactor VerifyCertificateChain test data to include a key purpose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py

Issue 2801813004: Refactor VerifyCertificateChain test data to include a key purpose (Closed)

Patch Set: Address mattm's comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/generate-target-and-intermediate.py ('k') | net/data/verify_certificate_chain_unittest/generate-target-has-pathlen-but-not-ca.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py b/net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py

index 585b02fee819afab192f0f00992a59e2c0f3a018..7d361dffa3a95ffed201bd7ad5489b8b13e12556 100755

--- a/net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py

+++ b/net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py

@@ -25,10 +25,12 @@ target.get_extensions().set_property('keyUsage',

chain = [target, intermediate]

trusted = common.TrustAnchor(root, constrained=False)

time = common.DEFAULT_TIME

+key_purpose = common.DEFAULT_KEY_PURPOSE

verify_result = False

errors = """----- Certificate i=0 (CN=Target) -----

ERROR: Target certificate looks like a CA but does not set all CA properties

"""

-common.write_test_file(__doc__, chain, trusted, time, verify_result, errors)

+common.write_test_file(__doc__, chain, trusted, time, key_purpose,

+ verify_result, errors)