net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py - Issue 2801813004: Refactor VerifyCertificateChain test data to include a key purpose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py

Issue 2801813004: Refactor VerifyCertificateChain test data to include a key purpose (Closed)

Patch Set: Address mattm's comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/generate-expired-target.py ('k') | net/data/verify_certificate_chain_unittest/generate-expired-unconstrained-root.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py b/net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py

index 2d077c8be27e9fe5c3c1498fd92fa72e50c18860..a04f2f4ce76717844b79c45480b4f7c27c19b86e 100755

--- a/net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py

+++ b/net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py

@@ -27,10 +27,12 @@ trusted = common.TrustAnchor(root, constrained=False)

# Both the root and intermediate are valid at this time, however the

# target is not.

time = common.MARCH_1_2015_UTC

+key_purpose = common.DEFAULT_KEY_PURPOSE

verify_result = False

errors = """----- Certificate i=0 (CN=Target) -----

ERROR: Time is before notBefore

"""

-common.write_test_file(__doc__, chain, trusted, time, verify_result, errors)

+common.write_test_file(__doc__, chain, trusted, time, key_purpose,

+ verify_result, errors)