Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: net/cert/internal/verify_certificate_chain_unittest.cc

Issue 2801813004: Refactor VerifyCertificateChain test data to include a key purpose (Closed)
Patch Set: Address mattm's comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/internal/verify_certificate_chain.h" 5 #include "net/cert/internal/verify_certificate_chain.h"
6 6
7 #include "net/cert/internal/signature_policy.h" 7 #include "net/cert/internal/signature_policy.h"
8 #include "net/cert/internal/trust_store.h" 8 #include "net/cert/internal/trust_store.h"
9 #include "net/cert/internal/verify_certificate_chain_typed_unittest.h" 9 #include "net/cert/internal/verify_certificate_chain_typed_unittest.h"
10 10
11 namespace net { 11 namespace net {
12 12
13 namespace { 13 namespace {
14 14
15 class VerifyCertificateChainDelegate { 15 class VerifyCertificateChainDelegate {
16 public: 16 public:
17 static void Verify(const ParsedCertificateList& chain, 17 static void Verify(const VerifyCertChainTest& test,
18 const scoped_refptr<TrustAnchor>& trust_anchor,
19 const der::GeneralizedTime& time,
20 bool expected_result,
21 const std::string& expected_errors,
22 const std::string& test_file_path) { 18 const std::string& test_file_path) {
23 ASSERT_TRUE(trust_anchor); 19 ASSERT_TRUE(test.trust_anchor);
24 20
25 SimpleSignaturePolicy signature_policy(1024); 21 SimpleSignaturePolicy signature_policy(1024);
26 22
27 CertPathErrors errors; 23 CertPathErrors errors;
28 bool result = VerifyCertificateChain(chain, trust_anchor.get(), 24 bool result = VerifyCertificateChain(test.chain, test.trust_anchor.get(),
29 &signature_policy, time, &errors); 25 &signature_policy, test.time, &errors);
30 EXPECT_EQ(expected_result, result); 26 EXPECT_EQ(test.expected_result, result);
31 EXPECT_EQ(expected_errors, errors.ToDebugString(chain)) 27 EXPECT_EQ(test.expected_errors, errors.ToDebugString(test.chain))
32 << "Test file: " << test_file_path; 28 << "Test file: " << test_file_path;
33 EXPECT_EQ(result, !errors.ContainsHighSeverityErrors()); 29 EXPECT_EQ(result, !errors.ContainsHighSeverityErrors());
34 } 30 }
35 }; 31 };
36 32
37 } // namespace 33 } // namespace
38 34
39 INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain, 35 INSTANTIATE_TYPED_TEST_CASE_P(VerifyCertificateChain,
40 VerifyCertificateChainSingleRootTest, 36 VerifyCertificateChainSingleRootTest,
41 VerifyCertificateChainDelegate); 37 VerifyCertificateChainDelegate);
42 38
43 } // namespace net 39 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698