|
|
Chromium Code Reviews
DescriptionAdding malloc allocator metric for objects allocated through shim
BUG=chromium:713191
Review-Url: https://codereview.chromium.org/2801153004
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/43f23c5d1d94df7282984a968e14731d6f7c9dd3
Patch Set 1 #Patch Set 2 : nit #Patch Set 3 : fix unittests #Patch Set 4 : nit #Patch Set 5 : presubmit #
Messages
Total messages: 33 (20 generated)
Description was changed from ========== [draft] malloc internal metrics BUG=catapult:# ========== to ========== [draft] malloc internal metrics BUG=713191 ==========
Description was changed from ========== [draft] malloc internal metrics BUG=713191 ========== to ========== [draft] malloc internal metrics BUG=chrome:713191 ==========
Description was changed from ========== [draft] malloc internal metrics BUG=chrome:713191 ========== to ========== Adding malloc allocator metric for objects allocated through shim BUG=chromium:713191 ==========
etienneb@chromium.org changed reviewers: + benjhayden@chromium.org
PTAL This CL is related to: https://codereview.chromium.org/2865333002
Description was changed from ========== Adding malloc allocator metric for objects allocated through shim BUG=chromium:713191 ========== to ========== Adding malloc allocator metric for objects allocated through shim BUG=chromium:713191 ==========
The CQ bit was checked by etienneb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
benjhayden@chromium.org changed reviewers: + hjd@chromium.org
I defer to hjd
benjhayden@chromium.org changed reviewers: - benjhayden@chromium.org
On 2017/05/24 21:53:35, benjhayden wrote: > I defer to hjd lgtm, thanks!
The CQ bit was checked by etienneb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
I believe hjd@ can't approve that CL:
"""
Missing LGTM from an OWNER for these files:
tracing/tracing/metrics/system_health/memory_metric.html
tracing/tracing/metrics/system_health/memory_metric_test.html
"""
On 2017/05/25 15:23:21, etienneb wrote: > I believe hjd@ can't approve that CL: > > """ > Missing LGTM from an OWNER for these files: > tracing/tracing/metrics/system_health/memory_metric.html > > tracing/tracing/metrics/system_health/memory_metric_test.html > > """ Sorry I should have been explicit that it was a non-owner lgtm, you'll still need Ben's stamp.
etienneb@chromium.org changed reviewers: + benjhayden@chromium.org
Ben, we need a owner approval.
lgtm
The CQ bit was checked by etienneb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
The CQ bit was checked by etienneb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from benjhayden@chromium.org, hjd@chromium.org Link to the patchset: https://codereview.chromium.org/2801153004/#ps80001 (title: "presubmit")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495741534110600,
"parent_rev": "81141992b3456e0c9f12eb9da3f2728b0fcefa3f", "commit_rev":
"43f23c5d1d94df7282984a968e14731d6f7c9dd3"}
Message was sent while issue was closed.
Description was changed from ========== Adding malloc allocator metric for objects allocated through shim BUG=chromium:713191 ========== to ========== Adding malloc allocator metric for objects allocated through shim BUG=chromium:713191 Review-Url: https://codereview.chromium.org/2801153004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
