Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2801153004: Adding malloc allocator metric for objects allocated through shim (Closed)

Created:
3 years, 8 months ago by etienneb
Modified:
3 years, 7 months ago
Reviewers:
benjhayden, hjd
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : fix unittests #

Patch Set 4 : nit #

Patch Set 5 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M tracing/tracing/metrics/system_health/memory_metric.html View 1 2 3 4 4 chunks +16 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric_test.html View 1 2 3 4 6 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 33 (20 generated)
etienneb
PTAL This CL is related to: https://codereview.chromium.org/2865333002
3 years, 7 months ago (2017-05-23 17:06:03 UTC) #5
benjhayden
I defer to hjd
3 years, 7 months ago (2017-05-24 21:53:35 UTC) #12
hjd
On 2017/05/24 21:53:35, benjhayden wrote: > I defer to hjd lgtm, thanks!
3 years, 7 months ago (2017-05-25 12:15:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801153004/60001
3 years, 7 months ago (2017-05-25 15:13:26 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/7287)
3 years, 7 months ago (2017-05-25 15:16:18 UTC) #18
etienneb
I believe hjd@ can't approve that CL: """ Missing LGTM from an OWNER for these ...
3 years, 7 months ago (2017-05-25 15:23:21 UTC) #19
hjd
On 2017/05/25 15:23:21, etienneb wrote: > I believe hjd@ can't approve that CL: > > ...
3 years, 7 months ago (2017-05-25 15:25:40 UTC) #20
etienneb
Ben, we need a owner approval.
3 years, 7 months ago (2017-05-25 15:28:08 UTC) #22
benjhayden
lgtm
3 years, 7 months ago (2017-05-25 17:07:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801153004/60001
3 years, 7 months ago (2017-05-25 19:25:58 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/7293)
3 years, 7 months ago (2017-05-25 19:28:28 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801153004/80001
3 years, 7 months ago (2017-05-25 19:45:38 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 20:09:37 UTC) #33
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698