Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2865333002:
Adding malloc allocator metric for objects allocated through shim (Closed)
DescriptionAdding malloc allocator metric for objects allocated through shim
CC=erikchen@chromium.org,chrisha@chromium.org
R=primiano@chromium.org
BUG=713191
Review-Url: https://codereview.chromium.org/2865333002
Cr-Commit-Position: refs/heads/master@{#470640}
Committed: https://chromium.googlesource.com/chromium/src/+/c9079413f6fdd2320ebd14f13db182910a9229b1
Patch Set 1 #
Messages
Total messages: 16 (7 generated)
erikchen@chromium.org changed reviewers: + erikchen@chromium.org
lgtm
Primiano, PTAL.
dskiba@chromium.org changed reviewers: + dskiba@chromium.org
We discussed in our team about adding something like that just today. LGTM! Next step is to expose (parse) it in telemetry?
> Next step is to expose (parse) it in telemetry? Yes, CL is already done. This is a split of the whole CL.
This lgtm although I would consider having a - - enable-heap-profiling=summary-only or similar otherwise I fear that the serialization of the heap profiler itself is going to bite you in various forms (unpredictability of the results due to estimation, hitting trace size limits in telemetry)
The CQ bit was checked by primiano@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by etienneb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494431333394710, "parent_rev":
"b0ee02fb6848c17831135cb5866eba6e8638adf8", "commit_rev":
"c9079413f6fdd2320ebd14f13db182910a9229b1"}
Message was sent while issue was closed.
Description was changed from ========== Adding malloc allocator metric for objects allocated through shim CC=erikchen@chromium.org,chrisha@chromium.org R=primiano@chromium.org BUG=713191 ========== to ========== Adding malloc allocator metric for objects allocated through shim CC=erikchen@chromium.org,chrisha@chromium.org R=primiano@chromium.org BUG=713191 Review-Url: https://codereview.chromium.org/2865333002 Cr-Commit-Position: refs/heads/master@{#470640} Committed: https://chromium.googlesource.com/chromium/src/+/c9079413f6fdd2320ebd14f13db1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c9079413f6fdd2320ebd14f13db1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
